Issue #20311: Revert 033137c12d88, select.epoll.poll() rounds again the timeout

towards zero

diff --git a/Lib/test/test_epoll.py b/Lib/test/test_epoll.py
index 46d2968b093e66c9960b2065353aec90c7816f2f..871efb2d31436a5b719bbaaab33d0443f50cdb53 100644 (file)
--- a/Lib/test/test_epoll.py
+++ b/Lib/test/test_epoll.py
@@ -217,17 +217,6 @@ class TestEPoll(unittest.TestCase):
         server.close()
         ep.unregister(fd)
 
-    def test_timeout_rounding(self):
-        # epoll_wait() has a resolution of 1 millisecond, check if the timeout
-        # is correctly rounded to the upper bound
-        epoll = select.epoll()
-        self.addCleanup(epoll.close)
-        for timeout in (1e-2, 1e-3, 1e-4):
-            t0 = time.monotonic()
-            epoll.poll(timeout)
-            dt = time.monotonic() - t0
-            self.assertGreaterEqual(dt, timeout)
-
 
 def test_main():
     support.run_unittest(TestEPoll)

diff --git a/Misc/NEWS b/Misc/NEWS
index 2de9b3124bb41a02c2ac7c3e330b45b452c551d5..ea6f1d738441cfbe394cb987871375cb4c17bb50 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -58,10 +58,6 @@ Library
 
 - Issue #20374: Fix build with GNU readline >= 6.3.
 
-- Issue #20311: select.epoll.poll() now rounds the timeout away from zero,
-  instead of rounding towards zero. For example, a timeout of one microsecond
-  is now rounded to one millisecond, instead of being rounded to zero.
-
 - Issue #20262: Warnings are raised now when duplicate names are added in the
   ZIP file or too long ZIP file comment is truncated.
 
@@ -278,7 +274,7 @@ IDLE
 
 --Issue #17390: Add Python version to Idle editor window title bar.
   Original patches by Edmond Burnett and Kent Johnson.
-  
+
 - Issue #18960: IDLE now ignores the source encoding declaration on the second
   line if the first line contains anything except a comment.
 

diff --git a/Modules/selectmodule.c b/Modules/selectmodule.c
index ab2016a981912efad5bc507c4fa2c3e07735180e..c492224ecbcf32a4172f6ac4502b2cde220ca1ad 100644 (file)
--- a/Modules/selectmodule.c
+++ b/Modules/selectmodule.c
@@ -1379,9 +1379,7 @@ pyepoll_poll(pyEpoll_Object *self, PyObject *args, PyObject *kwds)
         return NULL;
     }
     else {
-        /* epoll_wait() has a resolution of 1 millisecond, round away from zero
-           to wait *at least* dtimeout seconds. */
-        timeout = (int)ceil(dtimeout * 1000.0);
+        timeout = (int)(dtimeout * 1000.0);
     }
 
     if (maxevents == -1) {