Add a note explaining why dict_update() doesn't use METH_FASTCALL

Issue #29312.

diff --git a/Objects/dictobject.c b/Objects/dictobject.c
index 1a6eedd738c4192ea38dc9f1c561e78b687eb0e0..f9414865adeda548448ae750b433828c2f74d6ea 100644 (file)
--- a/Objects/dictobject.c
+++ b/Objects/dictobject.c
@@ -2347,6 +2347,9 @@ dict_update_common(PyObject *self, PyObject *args, PyObject *kwds,
     return result;
 }
 
+/* Note: dict.update() uses the METH_VARARGS|METH_KEYWORDS calling convention.
+   Using METH_FASTCALL would make dict.update(**dict2) calls slower, see the
+   issue #29312. */
 static PyObject *
 dict_update(PyObject *self, PyObject *args, PyObject *kwds)
 {