]> granicus.if.org Git - python/commitdiff
Skip test if zlib not present. Closes #11498. Patch by Natalia B. Bidart.
authorEric V. Smith <eric@trueblade.com>
Mon, 14 Mar 2011 15:57:16 +0000 (11:57 -0400)
committerEric V. Smith <eric@trueblade.com>
Mon, 14 Mar 2011 15:57:16 +0000 (11:57 -0400)
Lib/importlib/_bootstrap.py
Lib/test/test_zipfile.py
Misc/ACKS

index 7710e8cf5b12b73a9deb59836449f2ca664d28f6..87ff01f21953933749343cb7dc14ac9343b09312 100644 (file)
@@ -240,7 +240,7 @@ class BuiltinImporter:
     @classmethod
     @_requires_builtin
     def is_package(cls, fullname):
-        """Return None as built-in module are never packages."""
+        """Return None as built-in modules are never packages."""
         return False
 
 
index 8d51528ecc7ceaaa5762b9a23864235a71b4c89f..90aab8689cde7933028265679b60f41dc9d20566 100644 (file)
@@ -489,6 +489,7 @@ class TestsWithSourceFile(unittest.TestCase):
         except zipfile.BadZipFile:
             self.assertTrue(zipfp2.fp is None, 'zipfp is not closed')
 
+    @skipUnless(zlib, "requires zlib")
     def test_unicode_filenames(self):
         # bug #10801
         fname = findfile('zip_cp437_header.zip')
index 1abfa2662178a5b65d5b028b7a4f7f496d516b64..dfb61232ec8b97105b4be10ddf659cc331891ed6 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -80,6 +80,7 @@ Eric Beser
 Steven Bethard
 Stephen Bevan
 Ron Bickers
+Natalia B. Bidart
 Adrian von Bidder
 David Binger
 Dominic Binks