]> granicus.if.org Git - apache/commitdiff
* Play safe if the notes table does not contain an SSL_connect_rv key.
authorRuediger Pluem <rpluem@apache.org>
Fri, 11 Feb 2011 12:50:31 +0000 (12:50 +0000)
committerRuediger Pluem <rpluem@apache.org>
Fri, 11 Feb 2011 12:50:31 +0000 (12:50 +0000)
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1069785 13f79535-47bb-0310-9956-ffa450edef68

modules/proxy/mod_proxy_http.c

index 958e4e10d1bf26b60e7dd415cc8ad634bae15e93..7271ca17fbba60ac0ad3992905ff656440616152 100644 (file)
@@ -272,8 +272,10 @@ static int pass_brigade(apr_bucket_alloc_t *bucket_alloc,
                      "proxy: pass request body failed to %pI (%s)",
                      p_conn->addr, p_conn->hostname);
         if (origin->aborted) {
-            if (strcmp(apr_table_get(origin->notes,
-                                     "SSL_connect_rv"), "err") == 0) {
+            const char *ssl_note;
+
+            if (((ssl_note = apr_table_get(origin->notes, "SSL_connect_rv"))
+                != NULL) && (strcmp(ssl_note, "err") == 0)) {
                 return ap_proxyerror(r, HTTP_INTERNAL_SERVER_ERROR,
                                      "Error during SSL Handshake with"
                                      " remote server");