Relevant BUGIDs:

Purpose of commit: new testcase

Commit summary:
---------------

2007-10-12  Thorsten Kukuk  <kukuk@thkukuk.de>

        * xtests/Makefile.am: Add tst-pam_dispatch5 sources
        * xtests/tst-pam_dispatch5.c: New test for jump too far.
        * xtests/tst-pam_dispatch5.pamd: New test configuration.

diff --git a/ChangeLog b/ChangeLog
index c609a109c24c8e9ec1fff34afaa1924d2969a0f1..a7284ca57d784dfb74bad4675d6231f397cecd7a 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2007-10-12  Thorsten Kukuk  <kukuk@thkukuk.de>
+
+       * xtests/Makefile.am: Add tst-pam_dispatch5 sources
+       * xtests/tst-pam_dispatch5.c: New test for jump too far.
+       * xtests/tst-pam_dispatch5.pamd: New test configuration.
+
 2007-10-09  Tomas Mraz  <t8m@centrum.cz>
        * modules/pam_tally/pam_tally.8.xml: Document audit option
        correctly.

diff --git a/xtests/Makefile.am b/xtests/Makefile.am
index b32ba76b605d0f5fbc6a6a3ba6a30aab40a09c7c..8b6dbd2592b28da22f54c90ad0422635f5b25204 100644 (file)
--- a/xtests/Makefile.am
+++ b/xtests/Makefile.am
@@ -11,6 +11,7 @@ CLEANFILES = *~
 
 EXTRA_DIST = run-xtests.sh tst-pam_dispatch1.pamd tst-pam_dispatch2.pamd \
        tst-pam_dispatch3.pamd tst-pam_dispatch4.pamd \
+       tst-pam_dispatch5.pamd \
        tst-pam_cracklib1.pamd tst-pam_cracklib2.pamd \
        tst-pam_unix1.pamd tst-pam_unix2.pamd tst-pam_unix3.pamd \
        tst-pam_unix1.sh tst-pam_unix2.sh tst-pam_unix3.sh \
@@ -23,7 +24,8 @@ EXTRA_DIST = run-xtests.sh tst-pam_dispatch1.pamd tst-pam_dispatch2.pamd \
        group.conf tst-pam_group1.pamd tst-pam_group1.sh
 
 XTESTS = tst-pam_dispatch1 tst-pam_dispatch2 tst-pam_dispatch3 \
-       tst-pam_dispatch4 tst-pam_cracklib1 tst-pam_cracklib2 \
+       tst-pam_dispatch4 tst-pam_dispatch5 \
+       tst-pam_cracklib1 tst-pam_cracklib2 \
        tst-pam_unix1 tst-pam_unix2 tst-pam_unix3 \
        tst-pam_access1 tst-pam_access2 tst-pam_access3 \
        tst-pam_access4 tst-pam_limits1 tst-pam_succeed_if1 \

diff --git a/xtests/tst-pam_dispatch4.c b/xtests/tst-pam_dispatch4.c
index 12bc362aa5783d3fddc5a57322ab903d76058fd7..745e9cfc962a47e24e7993be6ece3c8acd951444 100644 (file)
--- a/xtests/tst-pam_dispatch4.c
+++ b/xtests/tst-pam_dispatch4.c
@@ -64,7 +64,7 @@ main(int argc, char *argv[])
   if (retval != PAM_SUCCESS)
     {
       if (debug)
-       fprintf (stderr, "test4: pam_start returned %d\n", retval);
+       fprintf (stderr, "pam_dispatch4: pam_start returned %d\n", retval);
       return 1;
     }
 
@@ -72,7 +72,7 @@ main(int argc, char *argv[])
   if (retval != PAM_SUCCESS)
     {
       if (debug)
-       fprintf (stderr, "test4: pam_authenticate returned %d\n", retval);
+       fprintf (stderr, "pam_dispatch4: pam_authenticate returned %d\n", retval);
       return 1;
     }
 
@@ -80,7 +80,7 @@ main(int argc, char *argv[])
   if (retval == PAM_SUCCESS)
     {
       if (debug)
-       fprintf (stderr, "test4: pam_authenticate returned %d\n", retval);
+       fprintf (stderr, "pam_dispatch4: pam_acct_mgmt returned %d\n", retval);
       return 1;
     }
 

diff --git a/xtests/tst-pam_dispatch5.c b/xtests/tst-pam_dispatch5.c
new file mode 100644 (file)
index 0000000..f1197b3
--- /dev/null
+++ b/xtests/tst-pam_dispatch5.c
@@ -0,0 +1,86 @@
+/*
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, and the entire permission notice in its entirety,
+ *    including the disclaimer of warranties.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ * 3. The name of the author may not be used to endorse or promote
+ *    products derived from this software without specific prior
+ *    written permission.
+ *
+ * ALTERNATIVELY, this product may be distributed under the terms of
+ * the GNU Public License, in which case the provisions of the GPL are
+ * required INSTEAD OF the above restrictions.  (This clause is
+ * necessary due to a potential bad interaction between the GPL and
+ * the restrictions contained in a BSD-style copyright.)
+ *
+ * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED
+ * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+ * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT,
+ * INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+ * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
+ * OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
+#include <stdio.h>
+#include <string.h>
+#include <security/pam_appl.h>
+#include <security/pam_misc.h>
+
+static struct pam_conv conv = {
+    misc_conv,
+    NULL
+};
+
+
+/* jump after the end of the stack and make sure we don't seg.fault. */
+
+int
+main(int argc, char *argv[])
+{
+  pam_handle_t *pamh=NULL;
+  const char *user="nobody";
+  int retval;
+  int debug = 0;
+
+  if (argc > 1 && strcmp (argv[1], "-d") == 0)
+    debug = 1;
+
+  retval = pam_start("tst-pam_dispatch5", user, &conv, &pamh);
+  if (retval != PAM_SUCCESS)
+    {
+      if (debug)
+       fprintf (stderr, "pam_dispatch5: pam_start returned %d\n", retval);
+      return 1;
+    }
+
+  retval = pam_authenticate (pamh, 0);
+  if (retval != PAM_PERM_DENIED)
+    {
+      if (debug)
+       fprintf (stderr, "pam_dispatch5: pam_authenticate returned %d\n", retval);
+      return 1;
+    }
+
+  retval = pam_end (pamh,retval);
+  if (retval != PAM_SUCCESS)
+    {
+      if (debug)
+       fprintf (stderr, "pam_dispatch5: pam_end returned %d\n", retval);
+      return 1;
+    }
+  return 0;
+}

diff --git a/xtests/tst-pam_dispatch5.pamd b/xtests/tst-pam_dispatch5.pamd
new file mode 100644 (file)
index 0000000..ea781f7
--- /dev/null
+++ b/xtests/tst-pam_dispatch5.pamd
@@ -0,0 +1,4 @@
+#%PAM-1.0
+# Jump after the end of the stack
+auth [success=2 default=bad] pam_permit.so
+auth required pam_deny.so