]> granicus.if.org Git - python/commitdiff
1 << 31 is invalid for signed integers, fix it by making 1 unsigned.
authorGregory P. Smith <greg@krypto.org>
Tue, 11 Dec 2012 01:44:44 +0000 (17:44 -0800)
committerGregory P. Smith <greg@krypto.org>
Tue, 11 Dec 2012 01:44:44 +0000 (17:44 -0800)
Found by Clang trunk's Undefined-Behavior Sanitizer.  [more to come]

Modules/_sre.c

index 38d0127c99bbcb6316fa1b11aaa2f38c4d59f69c..d74bf443a3439530ec9c7b253c926ea9a843a999 100644 (file)
@@ -452,7 +452,7 @@ SRE_CHARSET(SRE_CODE* set, SRE_CODE ch)
             }
             else {
                 /* <CHARSET> <bitmap> (32 bits per code word) */
-                if (ch < 256 && (set[ch >> 5] & (1 << (ch & 31))))
+                if (ch < 256 && (set[ch >> 5] & (1u << (ch & 31))))
                     return ok;
                 set += 8;
             }
@@ -491,7 +491,7 @@ SRE_CHARSET(SRE_CODE* set, SRE_CODE ch)
                     block = -1;
                 set += 64;
                 if (block >=0 &&
-                    (set[block*8 + ((ch & 255)>>5)] & (1 << (ch & 31))))
+                    (set[block*8 + ((ch & 255)>>5)] & (1u << (ch & 31))))
                     return ok;
                 set += count*8;
             }