more API review

git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@774207 283d02a7-25f6-0310-bc7c-ecb5cbfe19da

diff --git a/taglib/ape/apeitem.cpp b/taglib/ape/apeitem.cpp
index e34613b7def6711fcd3af60d0ac9d6991ca38d76..a6fe31b9ff3d706be3cbc2630bec65b1debc7554 100644 (file)
--- a/taglib/ape/apeitem.cpp
+++ b/taglib/ape/apeitem.cpp
@@ -147,6 +147,11 @@ StringList APE::Item::toStringList() const
   return d->text;
 }
 
+StringList APE::Item::values() const
+{
+  return d->text;
+}
+
 String APE::Item::toString() const
 {
   return isEmpty() ? String::null : d->text.front();

diff --git a/taglib/ape/apeitem.h b/taglib/ape/apeitem.h
index d4f63fe8c9fdbe205a2587dd7e394456ee98394e..8558bb35557bca186606a991c09b4d44e455d2ff 100644 (file)
--- a/taglib/ape/apeitem.h
+++ b/taglib/ape/apeitem.h
@@ -61,6 +61,7 @@ namespace TagLib {
       /*!
        * Constructs an item with \a key and \a value.
        */
+      // BIC: Remove this, StringList has a constructor from a single string
       Item(const String &key, const String &value);
 
       /*!
@@ -143,10 +144,16 @@ namespace TagLib {
       String toString() const;
 
       /*!
-       * Returns the value as a string list.
+       * \deprecated
+       * \see values
        */
       StringList toStringList() const;
 
+      /*!
+       * Returns the list of values.
+       */
+      StringList values() const;
+
       /*!
        * Render the item to a ByteVector.
        */

diff --git a/taglib/mpeg/id3v2/id3v2header.h b/taglib/mpeg/id3v2/id3v2header.h
index 9fd9619a094fc847593559521cede5d044f97954..99a7e7ff7cf373c57f2f744f680829088eb096a7 100644 (file)
--- a/taglib/mpeg/id3v2/id3v2header.h
+++ b/taglib/mpeg/id3v2/id3v2header.h
@@ -73,6 +73,10 @@ namespace TagLib {
        * Set the the major version number to \a version.  (Note: This is
        * the 4, not the 2 in ID3v2.4.0.  The 2 is implied.)
        * \see majorVersion()
+       *
+       * \note This is used by the internal parser; this will not change the
+       * version which is written and in general should not be called by API
+       * users.
        */
       void setMajorVersion(uint version);