[GISel][UnitTest] Fix a bunch of tests that were not doing anything

After r368065, all the tests using GISelMITest must call setUp() before
doing anything, otherwise the TargetMachine is not going to be set up.
A few tests added after that commit were not doing that and ended up
testing effectively nothing.

Fix the setup of all the tests and fix the failing tests.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@374595 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp b/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp
index 863a0a7215a237a30ff99297f739410a17463ac9..f7b037866e08b7269107d56268be43b854da2c66 100644 (file)
--- a/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp
+++ b/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp
@@ -120,17 +120,16 @@ TEST_F(GISelMITest, TestKnownBits) {
 }
 
 TEST_F(GISelMITest, TestSignBitIsZero) {
+  setUp();
   if (!TM)
     return;
 
   const LLT S32 = LLT::scalar(32);
-  auto SignBit = B.buildConstant(S32, 0x8000000);
+  auto SignBit = B.buildConstant(S32, 0x80000000);
   auto Zero = B.buildConstant(S32, 0);
 
   GISelKnownBits KnownBits(*MF);
 
   EXPECT_TRUE(KnownBits.signBitIsZero(Zero.getReg(0)));
-  EXPECT_FALSE(KnownBits.signBitIsZero(Zero.getReg(0)));
   EXPECT_FALSE(KnownBits.signBitIsZero(SignBit.getReg(0)));
-  EXPECT_TRUE(KnownBits.signBitIsZero(SignBit.getReg(0)));
 }

diff --git a/unittests/CodeGen/GlobalISel/MachineIRBuilderTest.cpp b/unittests/CodeGen/GlobalISel/MachineIRBuilderTest.cpp
index f39c28dc64854d5c8bebc3c5551095cf987c5e4e..7e633c5ac3f307cc15d2316e362bdb3c641a34c3 100644 (file)
--- a/unittests/CodeGen/GlobalISel/MachineIRBuilderTest.cpp
+++ b/unittests/CodeGen/GlobalISel/MachineIRBuilderTest.cpp
@@ -74,6 +74,7 @@ TEST_F(GISelMITest, TestBuildConstantFConstantDeath) {
 #endif
 
 TEST_F(GISelMITest, DstOpSrcOp) {
+  setUp();
   if (!TM)
     return;
 
@@ -99,6 +100,7 @@ TEST_F(GISelMITest, DstOpSrcOp) {
 }
 
 TEST_F(GISelMITest, BuildUnmerge) {
+  setUp();
   if (!TM)
     return;
 
@@ -119,6 +121,7 @@ TEST_F(GISelMITest, BuildUnmerge) {
 }
 
 TEST_F(GISelMITest, TestBuildFPInsts) {
+  setUp();
   if (!TM)
     return;
 
@@ -154,6 +157,7 @@ TEST_F(GISelMITest, TestBuildFPInsts) {
 }
 
 TEST_F(GISelMITest, BuildIntrinsic) {
+  setUp();
   if (!TM)
     return;
 
@@ -182,6 +186,7 @@ TEST_F(GISelMITest, BuildIntrinsic) {
 }
 
 TEST_F(GISelMITest, BuildXor) {
+  setUp();
   if (!TM)
     return;
 
@@ -210,6 +215,7 @@ TEST_F(GISelMITest, BuildXor) {
 }
 
 TEST_F(GISelMITest, BuildBitCounts) {
+  setUp();
   if (!TM)
     return;
 
@@ -237,6 +243,7 @@ TEST_F(GISelMITest, BuildBitCounts) {
 }
 
 TEST_F(GISelMITest, BuildCasts) {
+  setUp();
   if (!TM)
     return;
 
@@ -261,6 +268,7 @@ TEST_F(GISelMITest, BuildCasts) {
 }
 
 TEST_F(GISelMITest, BuildMinMax) {
+  setUp();
   if (!TM)
     return;
 
@@ -286,6 +294,7 @@ TEST_F(GISelMITest, BuildMinMax) {
 }
 
 TEST_F(GISelMITest, BuildAtomicRMW) {
+  setUp();
   if (!TM)
     return;