* src/useradd.c: When exiting because of a failure, warn if an

	home directory created, but cannot be removed.

diff --git a/ChangeLog b/ChangeLog
index e20922cdb5c9195e3f3a4e3c308151fd70aa4fe0..af852475ebe476957dfbdd358aada21f1a117250 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2010-03-18  Nicolas François  <nicolas.francois@centraliens.net>
+
+       * src/useradd.c: When exiting because of a failure, warn if an
+       home directory created, but cannot be removed.
+
 2010-03-18  Nicolas François  <nicolas.francois@centraliens.net>
 
        * libmisc/chowndir.c: Re-indent.

diff --git a/src/useradd.c b/src/useradd.c
index ee656f7c8ece5fd1d261cf7571d8e859695e2a27..31377c5c087bc89c924da4a994853d35b005a21f 100644 (file)
--- a/src/useradd.c
+++ b/src/useradd.c
@@ -208,7 +208,12 @@ static void create_mail (void);
 static void fail_exit (int code)
 {
        if (home_added) {
-               rmdir (user_home);
+               if (rmdir (user_home) != 0) {
+                       frpintf (stderr,
+                                _("%s: %s was created, but could not be removed\n"),
+                                Prog, user_home);
+                       SYSLOG ((LOG_ERR, "failed to remove %s", user_home));
+               }
        }
 
        if (spw_locked) {