curl_multi_socket() fix thanks to Jeff's test code

diff --git a/CHANGES b/CHANGES
index ac973884bd727341d9decb63d216f92987c110e4..28a506a98a877e8eb660aaeaa16fe7d61d72668e 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -6,6 +6,22 @@
 
                                   Changelog
 
+Daniel (11 September 2006)
+- Jeff Pohlmeyer presented a *multi_socket()-using program that exposed a
+  problem with it (SIGSEGV-style). It clearly showed that the existing
+  socket-state and state-difference function wasn't good enough so I rewrote
+  it and could then re-run Jeff's program without any crash. The previous
+  version clearly could miss to tell the application when a handle changed
+  from using one socket to using another.
+
+  While I was at it (as I could use this as a means to track this problem
+  down), I've now added a 'magic' number to the easy handle struct that is
+  inited at curl_easy_init() time and cleared at curl_easy_cleanup() time that
+  we can use internally to detect that an easy handle seems to be fine, or at
+  least not closed or freed (freeing in debug builds fill the area with 0x13
+  bytes but in normal builds we can of course not assume any particular data
+  in the freed areas).
+
 Daniel (9 September 2006)
 - Michele Bini fixed how the hostname is put in NTLM packages. As servers
   don't expect fully qualified names we need to cut them off at the first dot.

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 942f59f7f566a2fb6810dbb5587b61dcfb6a3328..9d32c39a258db083f2b43562d0dd5d7fd27afb8d 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -19,6 +19,7 @@ This release includes the following changes:
 
 This release includes the following bugfixes:
 
+ o fixed a socket state problem with *multi_socket()
  o (HTTP) NTLM hostname fix
  o getsockname usage fixes
  o SOCKS5 proxy connects can now time-out
@@ -46,6 +47,6 @@ advice from friends like these:
 
  Domenico Andreoli, Armel Asselin, Gisle Vanem, Yang Tse, Andrew Biggs,
  Peter Sylvester, David McCreedy, Dmitriy Sergeyev, Dmitry Rechkin,
- Jari Sundell, Ravi Pratap, Michele Bini
+ Jari Sundell, Ravi Pratap, Michele Bini, Jeff Pohlmeyer
 
         Thanks! (and sorry if I forgot to mention someone)