]> granicus.if.org Git - linux-pam/commitdiff
pam_mkhomedir: Drop superfluous stat() call.
authorTomas Mraz <tmraz@fedoraproject.org>
Tue, 26 Aug 2014 12:08:28 +0000 (14:08 +0200)
committerTomas Mraz <tmraz@fedoraproject.org>
Tue, 26 Aug 2014 12:08:28 +0000 (14:08 +0200)
modules/pam_mkhomedir/mkhomedir_helper.c (create_homedir): Drop superfluous
stat() call.

modules/pam_mkhomedir/mkhomedir_helper.c

index f426d7216f2756d014fafac0a7ef23aefc83611d..9fafe6ab82e2e9bbf7f764c67cd55e62f12fff73 100644 (file)
@@ -231,7 +231,7 @@ create_homedir(const struct passwd *pwd,
       if ((srcfd = open(newsource, O_RDONLY)) < 0 || fstat(srcfd, &st) != 0)
       {
          pam_syslog(NULL, LOG_DEBUG,
-                   "unable to open src file %s: %m", newsource);
+                   "unable to open or stat src file %s: %m", newsource);
          closedir(d);
 
 #ifndef PATH_MAX
@@ -241,20 +241,6 @@ create_homedir(const struct passwd *pwd,
 
         return PAM_PERM_DENIED;
       }
-      if (stat(newsource, &st) != 0)
-       {
-         pam_syslog(NULL, LOG_DEBUG, "unable to stat src file %s: %m",
-                    newsource);
-         close(srcfd);
-         closedir(d);
-
-#ifndef PATH_MAX
-         free(newsource); newsource = NULL;
-         free(newdest); newdest = NULL;
-#endif
-
-         return PAM_PERM_DENIED;
-       }
 
       /* Open the dest file */
       if ((destfd = open(newdest, O_WRONLY | O_TRUNC | O_CREAT, 0600)) < 0)