bpo-29643: Fix check for --enable-optimizations (GH-129)

The presence of the ``--enable-optimizations`` flag is indicated by the
value of ``$enableval``, but the configure script was checking ``$withval``,
resulting in the ``--enable-optimizations`` flag being effectively ignored.

diff --git a/Misc/NEWS b/Misc/NEWS
index 260538b74023f547a21e2db86a3a3a2125b010d8..b41fd8d79f552f30a6f881cf45af5b366219d08b 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -991,6 +991,11 @@ Tools/Demos
 - Issue #28102: The zipfile module CLI now prints usage to stderr.
   Patch by Stephen J. Turnbull.
 
+Build
+-----
+
+- bpo-29643: Fix ``--enable-optimization`` didn't work.
+
 Tests
 -----
 

diff --git a/configure b/configure
index 26b4a052711b400c47167834dbb8e17de1d314f5..87504d206837baf5a5781b6e1cc44dcce7138af9 100755 (executable)
--- a/configure
+++ b/configure
@@ -6521,7 +6521,7 @@ $as_echo_n "checking for --enable-optimizations... " >&6; }
 # Check whether --enable-optimizations was given.
 if test "${enable_optimizations+set}" = set; then :
   enableval=$enable_optimizations;
-if test "$withval" != no
+if test "$enableval" != no
 then
   Py_OPT='true'
   { $as_echo "$as_me:${as_lineno-$LINENO}: result: yes" >&5

diff --git a/configure.ac b/configure.ac
index 8ab1c03ed891924a0252d271bf7c84c44653afc4..f9bd92ce3da29ea7674a32bd5fe511b1fc4c4d0a 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -1274,7 +1274,7 @@ Py_OPT='false'
 AC_MSG_CHECKING(for --enable-optimizations)
 AC_ARG_ENABLE(optimizations, AS_HELP_STRING([--enable-optimizations], [Enable expensive optimizations (PGO, etc).  Disabled by default.]),
 [
-if test "$withval" != no
+if test "$enableval" != no
 then
   Py_OPT='true'
   AC_MSG_RESULT(yes);