]> granicus.if.org Git - clang/commitdiff
Revert "[AST][OpenMP] OpenMP Sections / Section constructs contain Structured blocks"
authorRoman Lebedev <lebedev.ri@gmail.com>
Fri, 1 Feb 2019 22:43:08 +0000 (22:43 +0000)
committerRoman Lebedev <lebedev.ri@gmail.com>
Fri, 1 Feb 2019 22:43:08 +0000 (22:43 +0000)
Further reviews (D57594, D57615) have revealed that this was not reviewed,
and that the differential's description was not read during the review,
thus rendering this commit invalid.

This reverts commit r352882.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@352933 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaOpenMP.cpp
test/AST/ast-dump-openmp-sections.cpp [deleted file]

index 6b345bfd239543818424819b10e6bb1c2879cc83..6716329e26a4fcc40331286ad65e7a317c5a2fac 100644 (file)
@@ -5971,13 +5971,6 @@ StmtResult Sema::ActOnOpenMPSectionsDirective(ArrayRef<OMPClause *> Clauses,
     return StmtError();
   }
 
-  // 1.2.2 OpenMP Language Terminology
-  // Structured block - An executable statement with a single entry at the
-  // top and a single exit at the bottom.
-  // The point of exit cannot be a branch out of the structured block.
-  // longjmp() and throw() must not violate the entry/exit criteria.
-  cast<CapturedStmt>(AStmt)->getCapturedDecl()->setNothrow();
-
   setFunctionHasBranchProtectedScope();
 
   return OMPSectionsDirective::Create(Context, StartLoc, EndLoc, Clauses, AStmt,
@@ -5992,13 +5985,6 @@ StmtResult Sema::ActOnOpenMPSectionDirective(Stmt *AStmt,
 
   assert(isa<CapturedStmt>(AStmt) && "Captured statement expected");
 
-  // 1.2.2 OpenMP Language Terminology
-  // Structured block - An executable statement with a single entry at the
-  // top and a single exit at the bottom.
-  // The point of exit cannot be a branch out of the structured block.
-  // longjmp() and throw() must not violate the entry/exit criteria.
-  cast<CapturedStmt>(AStmt)->getCapturedDecl()->setNothrow();
-
   setFunctionHasBranchProtectedScope();
   DSAStack->setParentCancelRegion(DSAStack->isCancelRegion());
 
diff --git a/test/AST/ast-dump-openmp-sections.cpp b/test/AST/ast-dump-openmp-sections.cpp
deleted file mode 100644 (file)
index 79bb751..0000000
+++ /dev/null
@@ -1,57 +0,0 @@
-// RUN: %clang_cc1 -verify -fopenmp -ast-dump %s | FileCheck %s
-// RUN: %clang_cc1 -verify -fopenmp-simd -ast-dump %s | FileCheck %s
-// expected-no-diagnostics
-
-void sections() {
-#pragma omp sections
-  {
-#pragma omp section
-    {
-    }
-#pragma omp section
-    {
-    }
-  }
-}
-
-// CHECK: `-FunctionDecl
-// CHECK-NEXT:   `-CompoundStmt
-// CHECK-NEXT:     `-OMPSectionsDirective
-// CHECK-NEXT:       `-CapturedStmt
-// CHECK-NEXT:         `-CapturedDecl {{.*}} nothrow
-// CHECK-NEXT:           |-CompoundStmt
-// CHECK-NEXT:           | |-OMPSectionDirective
-// CHECK-NEXT:           | | `-CapturedStmt
-// CHECK-NEXT:           | |   `-CapturedDecl {{.*}} nothrow
-// CHECK-NEXT:           | |     |-CompoundStmt
-// CHECK-NEXT:           | |     `-ImplicitParamDecl
-// CHECK-NEXT:           | `-OMPSectionDirective
-// CHECK-NEXT:           |   `-CapturedStmt
-// CHECK-NEXT:           |     `-CapturedDecl {{.*}} nothrow
-// CHECK-NEXT:           |       |-CompoundStmt
-// CHECK-NEXT:           |       `-ImplicitParamDecl
-// CHECK-NEXT:           |-ImplicitParamDecl
-// CHECK-NEXT:           |-CXXRecordDecl
-// CHECK-NEXT:           | |-DefinitionData
-// CHECK-NEXT:           | | |-DefaultConstructor
-// CHECK-NEXT:           | | |-CopyConstructor
-// CHECK-NEXT:           | | |-MoveConstructor
-// CHECK-NEXT:           | | |-CopyAssignment
-// CHECK-NEXT:           | | |-MoveAssignment
-// CHECK-NEXT:           | | `-Destructor
-// CHECK-NEXT:           | `-CapturedRecordAttr
-// CHECK-NEXT:           |-CapturedDecl {{.*}} nothrow
-// CHECK-NEXT:           | |-CompoundStmt
-// CHECK-NEXT:           | `-ImplicitParamDecl
-// CHECK-NEXT:           |-CXXRecordDecl
-// CHECK-NEXT:           | |-DefinitionData
-// CHECK-NEXT:           | | |-DefaultConstructor
-// CHECK-NEXT:           | | |-CopyConstructor
-// CHECK-NEXT:           | | |-MoveConstructor
-// CHECK-NEXT:           | | |-CopyAssignment
-// CHECK-NEXT:           | | |-MoveAssignment
-// CHECK-NEXT:           | | `-Destructor
-// CHECK-NEXT:           | `-CapturedRecordAttr
-// CHECK-NEXT:           `-CapturedDecl {{.*}} nothrow
-// CHECK-NEXT:             |-CompoundStmt
-// CHECK-NEXT:             `-ImplicitParamDecl