string2timecode: don't truncate to int

The timecode is a long long, but it is computed as a product whose
all multiplicands are (unsigned) ints and so effectively has the value
of an (unsigned) int. Fix this, and use the full long long range,
by explicitly making one of the first two multiplicands a long long.

Found by Coverity Scan.

diff --git a/libass/ass.c b/libass/ass.c
index 69dec8d37af070f84530a7d21eafc4a44cfdd927..01dd2eb4009184c5fdc75c3ad20cd788c4b02560 100644 (file)
--- a/libass/ass.c
+++ b/libass/ass.c
@@ -188,7 +188,7 @@ static long long string2timecode(ASS_Library *library, char *p)
         ass_msg(library, MSGL_WARN, "Bad timestamp");
         return 0;
     }
-    tm = ((h * 60 + m) * 60 + s) * 1000 + ms * 10;
+    tm = ((h * 60LL + m) * 60 + s) * 1000 + ms * 10;
     return tm;
 }