]> granicus.if.org Git - clang/commitdiff
clang-format: Fix crasher when a UTF8 character is found in an escape
authorDaniel Jasper <djasper@google.com>
Mon, 20 Jul 2015 23:28:07 +0000 (23:28 +0000)
committerDaniel Jasper <djasper@google.com>
Mon, 20 Jul 2015 23:28:07 +0000 (23:28 +0000)
sequence. Discovered by the fuzzer.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@242738 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Format/Encoding.h
unittests/Format/FormatTest.cpp

index 766d29274ce66b64199fb91b6934a838c3ad31e0..592d7201a8ac64e2e204918058129e3353bdb864 100644 (file)
@@ -135,7 +135,7 @@ inline unsigned getEscapeSequenceLength(StringRef Text) {
         ++I;
       return I;
     }
-    return 2;
+    return 1 + getNumBytesForUTF8(Text[1]);
   }
 }
 
index b2c5307341d89d71de691dbd3abed65593a98da0..252ae4db3f82e73607f41226bcc447683163971c 100644 (file)
@@ -9555,6 +9555,11 @@ TEST_F(FormatTest, SplitsUTF8Strings) {
             "\"八九十\tqq\"",
             format("\"一\t二 \t三 四 五\t六 \t七 八九十\tqq\"",
                    getLLVMStyleWithColumns(11)));
+
+  // UTF8 character in an escape sequence.
+  EXPECT_EQ("\"aaaaaa\"\n"
+            "\"\\\xC2\x8D\"",
+            format("\"aaaaaa\\\xC2\x8D\"", getLLVMStyleWithColumns(10)));
 }
 
 TEST_F(FormatTest, HandlesDoubleWidthCharsInMultiLineStrings) {