]> granicus.if.org Git - llvm/commitdiff
JumpThreadingPass::UnfoldSelectInstr - silence static analyzer dyn_cast<> null derefe...
authorSimon Pilgrim <llvm-dev@redking.me.uk>
Thu, 17 Oct 2019 11:19:41 +0000 (11:19 +0000)
committerSimon Pilgrim <llvm-dev@redking.me.uk>
Thu, 17 Oct 2019 11:19:41 +0000 (11:19 +0000)
The static analyzer is warning about a potential null dereference, but we should be able to use cast<> directly and if not assert will fire for us.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@375103 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Transforms/Scalar/JumpThreading.cpp

index ef02318ebecb47d9177ebc9cb91c9459ba125dc8..5e983adbf55e604c6a333a0bf1308add60bae079 100644 (file)
@@ -2433,7 +2433,7 @@ void JumpThreadingPass::UnfoldSelectInstr(BasicBlock *Pred, BasicBlock *BB,
   //  |-----
   //  v
   // BB
-  BranchInst *PredTerm = dyn_cast<BranchInst>(Pred->getTerminator());
+  BranchInst *PredTerm = cast<BranchInst>(Pred->getTerminator());
   BasicBlock *NewBB = BasicBlock::Create(BB->getContext(), "select.unfold",
                                          BB->getParent(), BB);
   // Move the unconditional branch to NewBB.