]> granicus.if.org Git - python/commitdiff
Fix the transient refleaks in test_zipimport_support.
authorAntoine Pitrou <solipsis@pitrou.net>
Tue, 8 Dec 2009 19:25:51 +0000 (19:25 +0000)
committerAntoine Pitrou <solipsis@pitrou.net>
Tue, 8 Dec 2009 19:25:51 +0000 (19:25 +0000)
Diagnosis and original patch by Florent Xicluna (flox).

Lib/test/script_helper.py
Misc/ACKS

index af5252c8c4f67835aec255ab0eb986a5f476dee2..f29143057d40188ca9fb5f8e862babdbb8ba3cd2 100644 (file)
@@ -30,7 +30,8 @@ def kill_python(p):
     data = p.stdout.read()
     p.stdout.close()
     # try to cleanup the child so we don't appear to leak when running
-    # with regrtest -R.  This should be a no-op on Windows.
+    # with regrtest -R.
+    p.wait()
     subprocess._cleanup()
     return data
 
index 28f7538e29209770114898df41a30bb36c3e9d92..57972ebec10b8b18c287a5283f2ba58c2c722d12 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -819,6 +819,7 @@ Gordon Worley
 Thomas Wouters
 Heiko Wundram
 Doug Wyatt
+Florent Xicluna
 Ka-Ping Yee
 Bob Yodlowski
 Danny Yoo