sccmap: re-enable non-silent output when '-v' is passed

Unix command line tools generally have a “last option wins” kind of semantics,
wherein it is valid to pass options multiple times or in combination with other
options that do their opposite. Thus when calling `sccmap -S -v`, the user could
reasonably expect that `-v` (“verbose”) reversed the effect of `-S` (“silent”).
This is also what the man page implies. But this was not what the code was
doing.

diff --git a/CHANGELOG.md b/CHANGELOG.md
index b63c3f052573b6fb175c028925c95d73491f2920..bc9c1223eb36d46acd49663cd370e4efb2b00cd7 100644 (file)
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -24,6 +24,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   `libgvplugin_gs.so.6`) #2280
 - trailing commas issue with fdp layout #2282
 - Missing `-S` in `sccmap` man page usage summary.
+- In `sccmap`, a `-v` option following a `-S` option now re-enables strongly
+  connected component output that the man page implied.
 
 ## [6.0.1] – 2022-09-11
 

diff --git a/cmd/tools/sccmap.c b/cmd/tools/sccmap.c
index 58a51171c5e91636b2d79ce930394e67b7185a7b..2387bb3ce9db68ac3530961ed22c48eb87232cad 100644 (file)
--- a/cmd/tools/sccmap.c
+++ b/cmd/tools/sccmap.c
@@ -284,6 +284,7 @@ static void scanArgs(int argc, char **argv)
            break;
        case 'v':
            Verbose = 1;
+           Silent = 0;
            break;
        case 'S':
            Verbose = 0;