]> granicus.if.org Git - postgresql/commitdiff
Remove redundant initialization of a local variable.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 19 Feb 2018 04:32:56 +0000 (23:32 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 19 Feb 2018 04:32:56 +0000 (23:32 -0500)
In what was doubtless a typo, commit bf6c614a2 introduced a duplicate
initialization of a local variable.  This made Coverity unhappy, as well
as pretty much anybody reading the code.  We don't even have a real use
for the local variable, so just remove it.

src/backend/executor/nodeGroup.c

index c6efd64d00d1e13357e6070897d0bb9f3cd1adab..2ea80e817d4e3e388747a88226a4aeeeed892769 100644 (file)
@@ -162,7 +162,6 @@ GroupState *
 ExecInitGroup(Group *node, EState *estate, int eflags)
 {
        GroupState *grpstate;
-       AttrNumber *grpColIdx = grpColIdx = node->grpColIdx;
 
        /* check for unsupported flags */
        Assert(!(eflags & (EXEC_FLAG_BACKWARD | EXEC_FLAG_MARK)));
@@ -209,7 +208,7 @@ ExecInitGroup(Group *node, EState *estate, int eflags)
        grpstate->eqfunction =
                execTuplesMatchPrepare(ExecGetResultType(outerPlanState(grpstate)),
                                                           node->numCols,
-                                                          grpColIdx,
+                                                          node->grpColIdx,
                                                           node->grpOperators,
                                                           &grpstate->ss.ps);