Patch #627105: Document that SYSTEM_PAGE_SIZE really should not be

larger than the system page size.

diff --git a/Objects/obmalloc.c b/Objects/obmalloc.c
index 753b2ccfbcab7b8594c27b3bb2c5aa0003fb2bfb..a72d05aaf57713b0add0269af682456cb39aadcb 100644 (file)
--- a/Objects/obmalloc.c
+++ b/Objects/obmalloc.c
@@ -139,7 +139,10 @@
  * getpagesize() call or deduced from various header files. To make
  * things simpler, we assume that it is 4K, which is OK for most systems.
  * It is probably better if this is the native page size, but it doesn't
- * have to be.
+ * have to be.  In theory, if SYSTEM_PAGE_SIZE is larger than the native page 
+ * size, then `POOL_ADDR(p)->arenaindex' could rarely cause a segmentation 
+ * violation fault.  4K is apparently OK for all the platforms that python 
+ * currently targets.
  */
 #define SYSTEM_PAGE_SIZE       (4 * 1024)
 #define SYSTEM_PAGE_SIZE_MASK  (SYSTEM_PAGE_SIZE - 1)