]> granicus.if.org Git - php/commitdiff
Change pm.start_servers default warning to notice
authorDavid Zuelke <dzuelke@gmail.com>
Sun, 9 Nov 2014 01:18:58 +0000 (20:18 -0500)
committerRemi Collet <remi@php.net>
Fri, 21 Nov 2014 06:47:04 +0000 (07:47 +0100)
Unlike other settings, this has a perfectly reasonable default, calculated using
a dynamic formula. If the default was hardcoded to "2" or something, then it
would make sense to have a warning, since that could potentially be bad, but for
a dynamically calculated value based on other mandatory settings, a notice ought
to be enough.

sapi/fpm/fpm/fpm_conf.c

index 65a51f11c693a2c6acc55096440b6139935daa3e..6e255354fc947489d2a44b48f6d2cc58710ebc3b 100644 (file)
@@ -813,7 +813,7 @@ static int fpm_conf_process_all_pools() /* {{{ */
 
                        if (config->pm_start_servers <= 0) {
                                config->pm_start_servers = config->pm_min_spare_servers + ((config->pm_max_spare_servers - config->pm_min_spare_servers) / 2);
-                               zlog(ZLOG_WARNING, "[pool %s] pm.start_servers is not set. It's been set to %d.", wp->config->name, config->pm_start_servers);
+                               zlog(ZLOG_NOTICE, "[pool %s] pm.start_servers is not set. It's been set to %d.", wp->config->name, config->pm_start_servers);
 
                        } else if (config->pm_start_servers < config->pm_min_spare_servers || config->pm_start_servers > config->pm_max_spare_servers) {
                                zlog(ZLOG_ALERT, "[pool %s] pm.start_servers(%d) must not be less than pm.min_spare_servers(%d) and not greater than pm.max_spare_servers(%d)", wp->config->name, config->pm_start_servers, config->pm_min_spare_servers, config->pm_max_spare_servers);