Remove redundant break statements, and replace asserts with llvm_unreachable

Per John's review comments for r140068.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@140142 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/AST/Decl.cpp b/lib/AST/Decl.cpp
index 4aa1d22be01c4a5415f4379678ceb33995cce2e5..73a6558e10328b21a983d4a7ab7bc8cb7d4c38c5 100644 (file)
--- a/lib/AST/Decl.cpp
+++ b/lib/AST/Decl.cpp
@@ -1120,15 +1120,15 @@ QualifierInfo::setTemplateParameterListsInfo(ASTContext &Context,
 const char *VarDecl::getStorageClassSpecifierString(StorageClass SC) {
   switch (SC) {
   case SC_None:                 break;
-  case SC_Auto:                 return "auto"; break;
-  case SC_Extern:               return "extern"; break;
-  case SC_OpenCLWorkGroupLocal: return "<<work-group-local>>"; break;
-  case SC_PrivateExtern:        return "__private_extern__"; break;
-  case SC_Register:             return "register"; break;
-  case SC_Static:               return "static"; break;
+  case SC_Auto:                 return "auto";
+  case SC_Extern:               return "extern";
+  case SC_OpenCLWorkGroupLocal: return "<<work-group-local>>";
+  case SC_PrivateExtern:        return "__private_extern__";
+  case SC_Register:             return "register";
+  case SC_Static:               return "static";
   }
 
-  assert(0 && "Invalid storage class");
+  llvm_unreachable("Invalid storage class");
   return 0;
 }
 

diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp
index 52a05db7cfea17b8b82f1ab8d13ed93f9047e796..6ad8584469b8d468e7c63ce94db46d0d299169a4 100644 (file)
--- a/lib/Sema/SemaDecl.cpp
+++ b/lib/Sema/SemaDecl.cpp
@@ -6148,8 +6148,7 @@ void Sema::ActOnCXXForRangeDecl(Decl *D) {
     Error = 4;
     break;
   case SC_OpenCLWorkGroupLocal:
-    assert(0 && "Unexpected storage class");
-    break;
+    llvm_unreachable("Unexpected storage class");
   }
   // FIXME: constexpr isn't allowed here.
   //if (DS.isConstexprSpecified())