Check update constant failure in ReflectionClassConstant::__toString()

diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
index f62dd15e1c90e0c060449831980ce367ddb70be9..df00e5b4ba24a64a1579fc7e167c2c031d3d1931 100644 (file)
--- a/ext/reflection/php_reflection.c
+++ b/ext/reflection/php_reflection.c
@@ -547,7 +547,10 @@ static void _class_const_string(smart_str *str, char *name, zend_class_constant
        char *visibility = zend_visibility_string(Z_ACCESS_FLAGS(c->value));
        char *type;
 
-       zval_update_constant_ex(&c->value, c->ce);
+       if (zval_update_constant_ex(&c->value, c->ce) == FAILURE) {
+               return;
+       }
+
        type = zend_zval_type_name(&c->value);
 
        if (Z_TYPE(c->value) == IS_ARRAY) {

diff --git a/ext/reflection/tests/ReflectionClassConstant_toString_error.phpt b/ext/reflection/tests/ReflectionClassConstant_toString_error.phpt
new file mode 100644 (file)
index 0000000..cd4dfa3
--- /dev/null
+++ b/ext/reflection/tests/ReflectionClassConstant_toString_error.phpt
@@ -0,0 +1,18 @@
+--TEST--
+Exception thrown while converting ReflectionClassConstant to string
+--FILE--
+<?php
+
+class B {
+    const X = self::UNKNOWN;
+}
+
+try {
+    echo new ReflectionClassConstant('B', 'X');
+} catch (Error $e) {
+    echo $e->getMessage(), "\n";
+}
+
+?>
+--EXPECT--
+Undefined class constant 'self::UNKNOWN'