Disable creation of "ContentsOf" symbols. It was fundamentally broken on many

levels; eventually we will need a plug-in model (similar to GRTransferFuncs) to
represent symbolic memory.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@48399 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/Analysis/ValueState.cpp b/Analysis/ValueState.cpp
index 1fc4df9128e2d341973ca02ec93d9c99986f88e3..97df578eca3c7e609a4463e31e25fcb6f8c10c07 100644 (file)
--- a/Analysis/ValueState.cpp
+++ b/Analysis/ValueState.cpp
@@ -163,17 +163,29 @@ RVal ValueStateManager::GetRVal(ValueState* St, LVal LV, QualType T) {
       // FIXME: We should limit how far a "ContentsOf" will go...
       
     case lval::SymbolValKind: {
+      
+      
+      // FIXME: This is a broken representation of memory, and is prone
+      //  to crashing the analyzer when addresses to symbolic values are
+      //  passed through casts.  We need a better representation of symbolic
+      //  memory (or just memory in general); probably we should do this
+      //  as a plugin class (similar to GRTransferFuncs).
+      
+#if 0      
       const lval::SymbolVal& SV = cast<lval::SymbolVal>(LV);
       assert (T.getTypePtr());
       
       // Punt on "symbolic" function pointers.
       if (T->isFunctionType())
-        return UnknownVal();
-      
+        return UnknownVal();      
+
       if (T->isPointerType())
         return lval::SymbolVal(SymMgr.getContentsOfSymbol(SV.getSymbol()));
       else
         return nonlval::SymbolVal(SymMgr.getContentsOfSymbol(SV.getSymbol()));
+#endif
+      
+      return UnknownVal();
     }
       
     default: