Add self-assignment check in operator=

Method 'operator=' should check its argument with 'this' pointer.

diff --git a/taglib/mp4/mp4item.cpp b/taglib/mp4/mp4item.cpp
index 671f26b4d6cac6a2c6ffaf7991aaa8a49e6177ba..aa59fedadc21cc85e204c1821a0aa84e7aadabdd 100644 (file)
--- a/taglib/mp4/mp4item.cpp
+++ b/taglib/mp4/mp4item.cpp
@@ -64,11 +64,13 @@ MP4::Item::Item(const Item &item) : d(item.d)
 MP4::Item &
 MP4::Item::operator=(const Item &item)
 {
-  if(d->deref()) {
-    delete d;
+  if(&item != this) {
+    if(d->deref()) {
+      delete d;
+    }
+    d = item.d;
+    d->ref();
   }
-  d = item.d;
-  d->ref();
   return *this;
 }