Emit warnings if we are returning a reference to a local temporary.

The issue was brought to our attention by Matthieu Monrocq.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@120331 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/include/clang/Basic/DiagnosticSemaKinds.td b/include/clang/Basic/DiagnosticSemaKinds.td
index fd049e37d90f06446600c455d84f81748fa1876f..9404c6861d4ceb045342ec04b573433d1f066c75 100644 (file)
--- a/include/clang/Basic/DiagnosticSemaKinds.td
+++ b/include/clang/Basic/DiagnosticSemaKinds.td
@@ -3230,6 +3230,12 @@ def warn_ret_stack_addr : Warning<
   "address of stack memory associated with local variable %0 returned">;
 def warn_ret_stack_ref : Warning<
   "reference to stack memory associated with local variable %0 returned">;
+def warn_ret_local_temp_ref : Warning<
+  "returning reference to local temporary">;
+def warn_ret_local_temp_var_ref : Warning<
+  "reference to temporary associated with local variable %0 returned">;
+def note_local_temp_var_ref : Note<
+  "binding variable %0 to temporary here">;
 def warn_ret_addr_label : Warning<
   "returning address of label, which is local">;
 def err_ret_local_block : Error<

diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp
index ed45de53f264dcfc1e5a21af7947075c726b206a..807a5507508c6b1e056efaceb20c2f088109a705 100644 (file)
--- a/lib/Sema/SemaChecking.cpp
+++ b/lib/Sema/SemaChecking.cpp
@@ -1787,11 +1787,35 @@ Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
         << ALE->getSourceRange();
 
   } else if (lhsType->isReferenceType()) {
+    // Perform checking for local temporaries returned by reference.
+    if (RetValExp->Classify(Context).isPRValue()) {
+      Diag(RetValExp->getLocStart(), diag::warn_ret_local_temp_ref)
+        << RetValExp->getSourceRange();
+      return;
+    }
+
     // Perform checking for stack values returned by reference.
     // Check for a reference to the stack
-    if (DeclRefExpr *DR = EvalVal(RetValExp))
+    if (DeclRefExpr *DR = EvalVal(RetValExp)) {
+      const VarDecl *VD = cast<VarDecl>(DR->getDecl());
+      // Check for returning reference variable that binds to temporary.
+      if (VD->getType()->isReferenceType()) {
+        if (const Expr *init = VD->getInit())
+          if (init->Classify(Context).isPRValue()) {
+            Diag(DR->getLocStart(), diag::warn_ret_local_temp_var_ref)
+              << VD->getDeclName() << RetValExp->getSourceRange();
+            Diag(VD->getLocation(), diag::note_local_temp_var_ref)
+              << VD->getDeclName() << VD->getInit()->getSourceRange();
+          }
+
+        // When returning a reference variable that doesn't bind to temporary,
+        // no warning.
+        return;
+      }
+
       Diag(DR->getLocStart(), diag::warn_ret_stack_ref)
-        << DR->getDecl()->getDeclName() << RetValExp->getSourceRange();
+        << VD->getDeclName() << RetValExp->getSourceRange();
+    }
   }
 }
 
@@ -1953,7 +1977,7 @@ do {
     DeclRefExpr *DR = cast<DeclRefExpr>(E);
 
     if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
-      if (V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR;
+      if (V->hasLocalStorage()) return DR;
 
     return NULL;
   }

diff --git a/test/Analysis/stack-addr-ps.cpp b/test/Analysis/stack-addr-ps.cpp
index 593ba1df94d34d854d378853f96088cd4b7778af..8ecb6a67eaebb706ce386f89777063b4a83d5441 100644 (file)
--- a/test/Analysis/stack-addr-ps.cpp
+++ b/test/Analysis/stack-addr-ps.cpp
@@ -6,3 +6,12 @@ const int& g() {
   int s;
   return s; // expected-warning{{reference to stack memory associated with local variable 's' returned}}
 }
+
+int get_value();
+
+const int &get_reference1() { return get_value(); } // expected-warning {{returning reference to local temporary}}
+
+const int &get_reference2() {
+  int const& w2 = get_value(); // expected-note {{binding variable 'w2' to temporary here}}
+  return w2; // expected-warning {{reference to temporary associated with local variable 'w2' returned}}
+}

diff --git a/test/SemaCXX/rval-references.cpp b/test/SemaCXX/rval-references.cpp
index 30622ccbfed0b547f0742808bb84e7038d766ed7..2068642c9d06004c73c2d29df9dcc433924dd27c 100644 (file)
--- a/test/SemaCXX/rval-references.cpp
+++ b/test/SemaCXX/rval-references.cpp
@@ -6,7 +6,7 @@ typedef int& ilr;
 typedef ilr&& ilr_c2; // Collapses to int&
 
 irr ret_irr() {
-  return 0;
+  return 0; // expected-warning {{returning reference to local temporary}}
 }
 
 struct not_int {};