When calling a PyCFunction that has METH_KEYWORDS defined, don't

create an empty dictionary if it is called without keyword args.  Just
pass NULL.

XXX I had believed that this caused weird errors, but the test suite
runs cleanly.

diff --git a/Python/ceval.c b/Python/ceval.c
index 9d6549572f5600272ec3060a369a74956d72c993..8a83e99eadae931b5d759e3a0a5fd2aad272f6b7 100644 (file)
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -2728,16 +2728,6 @@ call_cfunction(PyObject *func, PyObject *arg, PyObject *kw)
        int flags = PyCFunction_GET_FLAGS(func);
 
        if (flags & METH_KEYWORDS) {
-               if (kw == NULL) {
-                       static PyObject *dict = NULL;
-                       if (dict == NULL) {
-                               dict = PyDict_New();
-                               if (dict == NULL)
-                                       return NULL;
-                       }
-                       kw = dict;
-                       Py_INCREF(dict);
-               }
                return (*(PyCFunctionWithKeywords)meth)(self, arg, kw);
        }
        if (kw != NULL && PyDict_Size(kw) != 0) {