]> granicus.if.org Git - python/commitdiff
Fix recently introduced test cases.
authorKristján Valur Jónsson <kristjan@ccpgames.com>
Thu, 15 Jan 2009 09:09:13 +0000 (09:09 +0000)
committerKristján Valur Jónsson <kristjan@ccpgames.com>
Thu, 15 Jan 2009 09:09:13 +0000 (09:09 +0000)
For datetime, gentoo didn't seem to mind the %e format for strftime.  So, we just excercise those instead making sure that we don't crash.
For test_os, two cases were incorrect.

Lib/test/test_datetime.py
Lib/test/test_os.py

index 89fa5c8e697b36254d6e41ee2d62bdd7cc07e6d5..24ec895cf49d172d1d723622fdf9638db1d07c29 100644 (file)
@@ -857,9 +857,18 @@ class TestDate(HarmlessMixedComparison, unittest.TestCase):
         self.assertEqual(t.strftime("'%z' '%Z'"), "'' ''")
 
         #make sure that invalid format specifiers are handled correctly
-        self.assertRaises(ValueError, t.strftime, "%e")
-        self.assertRaises(ValueError, t.strftime, "%")
-        self.assertRaises(ValueError, t.strftime, "%#")
+        #self.assertRaises(ValueError, t.strftime, "%e")
+        #self.assertRaises(ValueError, t.strftime, "%")
+        #self.assertRaises(ValueError, t.strftime, "%#")
+
+        #oh well, some systems just ignore those invalid ones.
+        #at least, excercise them to make sure that no crashes
+        #are generated
+        for f in ["%e", "%", "%#"]:
+            try:
+                t.strftime(f)
+            except ValueError:
+                pass
 
         #check that this standard extension works
         t.strftime("%f")
index c89a23f8d69cb7ad6f4031128bad979c8a734cf6..4702e7c1927fbbb59cad48be7ec4ed5c328122d9 100644 (file)
@@ -559,11 +559,11 @@ class TestInvalidFD(unittest.TestCase):
 
     def test_fchown(self):
         if hasattr(os, "fchown"):
-            self.assertRaises(OSError, os.fchmod, 10, -1, -1)
+            self.assertRaises(OSError, os.fchown, 10, -1, -1)
 
     def test_fpathconf(self):
         if hasattr(os, "fpathconf"):
-            self.assertRaises(OSError, os.fpathconf, 10, "foo")
+            self.assertRaises(OSError, os.fpathconf, 10, "PC_FILESIZEBITS")
 
     def test_ftruncate(self):
         if hasattr(os, "ftruncate"):