]> granicus.if.org Git - llvm/commitdiff
Add order-dependencies to object libraries
authorChris Bieneman <chris.bieneman@me.com>
Tue, 6 Aug 2019 19:41:23 +0000 (19:41 +0000)
committerChris Bieneman <chris.bieneman@me.com>
Tue, 6 Aug 2019 19:41:23 +0000 (19:41 +0000)
Summary: If you are generating an object library that depends on table-gen generate sources, you need the object library to depend on the tablgen target. Currently llvm_add_library doesn't add dependencies for object libraries at all, which is clearly problematic.

Reviewers: compnerd, hintonda, smeenai

Reviewed By: smeenai

Subscribers: mgorny, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D65818

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@368074 91177308-0d34-0410-b5e6-96231b3b80d8

cmake/modules/AddLLVM.cmake

index daea27bb53162f2ebe04829f3f26f8b2fae54e5b..a42c55e79f5a68452096d0f20e4e8d0428fcb126 100644 (file)
@@ -448,6 +448,9 @@ function(llvm_add_library name)
     list(APPEND objlibs ${obj_name})
 
     set_target_properties(${obj_name} PROPERTIES FOLDER "Object Libraries")
+    if(ARG_DEPENDS)
+      add_dependencies(${obj_name} ${ARG_DEPENDS})
+    endif()
   endif()
 
   if(ARG_SHARED AND ARG_STATIC)