]> granicus.if.org Git - p11-kit/commitdiff
debug: Work around cppcheck false-positives
authorDaiki Ueno <dueno@redhat.com>
Tue, 16 Oct 2018 16:05:10 +0000 (18:05 +0200)
committerDaiki Ueno <ueno@gnu.org>
Wed, 17 Oct 2018 08:13:32 +0000 (10:13 +0200)
https://trac.cppcheck.net/ticket/8794

common/debug.h

index 255c62c4bca00febee58213d5ab89f21c9f37c45..7ea36f31fd2fa2f0678556aeb66329ced232b025 100644 (file)
@@ -71,13 +71,13 @@ void              p11_debug_precond             (const char *format,
 #endif
 
 #define return_val_if_fail(x, v) \
-       do { if (!(x)) { \
+       do { if (x) { } else {                                                  \
             p11_debug_precond ("p11-kit: '%s' not true at %s\n", #x, __func__); \
             return v; \
        } } while (false)
 
 #define return_if_fail(x) \
-       do { if (!(x)) { \
+       do { if (x) { } else {                                          \
             p11_debug_precond ("p11-kit: '%s' not true at %s\n", #x, __func__); \
             return; \
        } } while (false)
@@ -100,7 +100,7 @@ void              p11_debug_precond             (const char *format,
        } while (false)
 
 #define warn_if_fail(x) \
-       do { if (!(x)) { \
+       do { if (x) { } else {                                          \
             p11_debug_precond ("p11-kit: '%s' not true at %s\n", #x, __func__); \
        } } while (false)