]> granicus.if.org Git - clang/commitdiff
Revert r120063, it was wrong.
authorJohn McCall <rjmccall@apple.com>
Mon, 29 Nov 2010 18:01:58 +0000 (18:01 +0000)
committerJohn McCall <rjmccall@apple.com>
Mon, 29 Nov 2010 18:01:58 +0000 (18:01 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@120296 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaDeclCXX.cpp
test/CXX/dcl.dcl/basic.namespace/namespace.udecl/p8.cpp

index 648e654fd7de3d6f1339adcb855bfbcf807c2b7a..d30faccf24a13d55fd8bbbf6cabb36a5049c945d 100644 (file)
@@ -3961,8 +3961,8 @@ bool Sema::CheckUsingDeclRedeclaration(SourceLocation UsingLoc,
   //   repeatedly where (and only where) multiple declarations are
   //   allowed.
   //
-  // That's in file contexts.
-  if (CurContext->isFileContext())
+  // That's in non-member contexts.
+  if (!CurContext->getRedeclContext()->isRecord())
     return false;
 
   NestedNameSpecifier *Qual
index 5ba22c84191bd8e1d2d2de54cb56d9d67a8d517b..466097171c8dec9381ceae7f17c4f15bd5a58172 100644 (file)
@@ -82,7 +82,7 @@ namespace test2 {
   template struct Derived<int>; // expected-note {{in instantiation of template class}}
 }
 
-// PR8668: redeclarations are not okay in a function.
+// Redeclarations are okay in a function.
 namespace test3 {
   namespace N {
     int f(int);
@@ -90,18 +90,9 @@ namespace test3 {
   }
 
   void g() {
-    using N::f; // expected-note {{previous using declaration}}
-    using N::f; // expected-error {{redeclaration of using decl}}
-    using N::type; // expected-note {{previous using declaration}}
-    using N::type; // expected-error {{redeclaration of using decl}}
-  }
-
-  void h() {
     using N::f;
+    using N::f;
+    using N::type;
     using N::type;
-    {
-      using N::f;
-      using N::type;
-    }
   }
 }