From: Peter T Mount <patches@maidast.demon.co.uk>

This has a problem when using any authentication other than trust or
ident.

Anything using libpq will hang, because the client will go into a loop
while connecting. The following patch simply comments out two lines (a do
and a while), removing the loop. Going through the new scheme, I can't see
why this do..while loop is in there.

diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
index ee95ac59de5dcfca07e2cfbf4f9e3bdf16dd4814..3ac229c5a82d32a7c701e3261055c266f0d38021 100644 (file)
--- a/src/interfaces/libpq/fe-connect.c
+++ b/src/interfaces/libpq/fe-connect.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *       $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.59 1998/01/26 01:42:28 scrappy Exp $
+ *       $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-connect.c,v 1.60 1998/01/28 03:42:27 scrappy Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -584,7 +584,6 @@ connectDB(PGconn *conn)
         * authentication request.
         */
 
-       do
        {
                int beresp;
 
@@ -645,7 +644,6 @@ connectDB(PGconn *conn)
                                        conn->errorMessage) != STATUS_OK)
                        goto connect_errReturn;
        }
-       while (areq != AUTH_REQ_OK);
 
        /* free the password so it's not hanging out in memory forever */
        if (conn->pgpass != NULL)