fix clang-tidy issues

src/image.h:12:22: warning: macro replacement list should be enclosed in parentheses [misc-macro-parentheses]
src/misc.h:8:20: warning: all parameters should be named in a function [readability-named-parameter]
src/fs.h:7:6: warning: function 'preparevnstatdir' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]

diff --git a/src/fs.c b/src/fs.c
index 8f2a19ace5cba3fb572e26f069fee760af2fee37..abf0035a1ae8f4b6551b9fb6da2763e8d16ba547 100644 (file)
--- a/src/fs.c
+++ b/src/fs.c
@@ -84,25 +84,25 @@ int mkpath(const char *dir, const mode_t mode)
        return ret;
 }
 
-void preparevnstatdir(const char *file, const char *user, const char *group)
+void preparevnstatdir(const char *dir, const char *user, const char *group)
 {
        int len, i, lastslash=0;
        char *path, *base;
 
-       if (file == NULL) {
+       if (dir == NULL) {
                return;
        }
 
-       len = strlen(file);
+       len = strlen(dir);
        if (len<2) {
                return;
        }
 
-       if (file[len-1] == '/') {
+       if (dir[len-1] == '/') {
                return;
        }
 
-       path = strdup(file);
+       path = strdup(dir);
        if (path == NULL) {
                return;
        }
@@ -115,7 +115,7 @@ void preparevnstatdir(const char *file, const char *user, const char *group)
        }
        free(path);
 
-       path = strdup(file);
+       path = strdup(dir);
        if (path == NULL) {
                return;
        }

diff --git a/src/image.h b/src/image.h
index 14283c641092054e16f7935f22af8139ad111700..e9188384d40f5179dcbdadf8c7a8437c0e45771e 100644 (file)
--- a/src/image.h
+++ b/src/image.h
@@ -9,7 +9,7 @@
 #include <gdfontg.h>   /* gdFontGetGiant() */
 
 /* rectangle size */
-#define YBEGINOFFSET -1
+#define YBEGINOFFSET (-1)
 #define YENDOFFSET 6
 
 /* donut size */

diff --git a/src/misc.h b/src/misc.h
index 845276cc2b650c7ad0a0146796605309be550dde..9910e1165373421879e69335fa870b8edd268932 100644 (file)
--- a/src/misc.h
+++ b/src/misc.h
@@ -5,7 +5,7 @@
 
 int kerneltest(void);
 int spacecheck(char *path);
-void sighandler(int);
+void sighandler(int sig);
 uint64_t getbtime(void);
 char *getvalue(uint64_t mb, uint64_t kb, int len, int type);
 char *getrate(uint64_t mb, uint64_t kb, uint32_t interval, int len);