make sure this is initialized to NULL as we don't check the return

value of the FormatMessage function; we could end up using a stale
pointer.

diff --git a/win32/winutil.c b/win32/winutil.c
index 6fccb041d79fcfa7ff0278cfd84abb6a87c92cb0..9f1bfa42fe388da2b6024374bff56bf7bf791770 100644 (file)
--- a/win32/winutil.c
+++ b/win32/winutil.c
@@ -26,9 +26,11 @@ PHPAPI char *php_win_err(int error)
        /* leak for now */
        if (buf) {
                free(buf);
-               buf = NULL;
        }
 #endif
+
+       buf = NULL;
+
        FormatMessage(
                FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM |   FORMAT_MESSAGE_IGNORE_INSERTS,
                NULL, error, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (LPTSTR)&buf, 0, NULL