Merge r1643825 from trunk:

* core: Fix -D[efined] or <Define>[d] variables lifetime accross restarts.
        PR 57328.

Submitted-by: Armin Abfalterer <a.abfalterer gmail.com>
Reviewed/Committed-by: ylavic

Submitted by: ylavic
Reviewed/backported by: jim

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1651083 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/CHANGES b/CHANGES
index f64a05c617e41da858f5cfe0a0e32a6e553a692c..2e5e08ab5d21dc1417b44d288e3a0d54cd7e94b8 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -5,7 +5,6 @@ Changes with Apache 2.4.11
   *) SECURITY: CVE-2014-3583 (cve.mitre.org)
      mod_proxy_fcgi: Fix a potential crash due to buffer over-read, with 
      response headers' size above 8K.  [Yann Ylavic, Jeff Trawick]
-
   *) SECURITY: CVE-2014-3581 (cve.mitre.org)
      mod_cache: Avoid a crash when Content-Type has an empty value.
      PR 56924.  [Mark Montague <mark catseye.org>, Jan Kaluza]
@@ -22,6 +21,9 @@ Changes with Apache 2.4.11
      request headers earlier.  Adds "MergeTrailers" directive to restore
      legacy behavior.  [Edward Lu, Yann Ylavic, Joe Orton, Eric Covener]
 
+  *) core: Fix -D[efined] or <Define>[d] variables lifetime accross restarts. 
+     PR 57328.  [Armin Abfalterer <a.abfalterer gmail.com>, Yann Ylavic].
+
   *) mod_proxy: Preserve original request headers even if they differ
      from the ones to be forwarded to the backend. PR 45387.
      [Yann Ylavic]

diff --git a/STATUS b/STATUS
index ee7ab09b71689be62451ffca1acc5bbf78c388d8..fcacd3be08fa91e665aa4c68f58022e8f763cc43 100644 (file)
--- a/STATUS
+++ b/STATUS
@@ -126,12 +126,6 @@ PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
      2.4.x patch: https://issues.apache.org/bugzilla/attachment.cgi?id=32209
      +1: druggeri, gsmith, rjung
 
-   * core: Fix -D[efined] or <Define>[d] variables lifetime accross restarts.
-           PR 57328.
-     trunk patch: http://svn.apache.org/r1643825
-     2.4.x patch: trunk works (module CHANGES)
-     +1: ylavic, rjung, trawick
-
 PATCHES PROPOSED TO BACKPORT FROM TRUNK:
   [ New proposals should be added at the end of the list ]
 

diff --git a/server/core.c b/server/core.c
index 9c2443baa6fe963e26eb6dfda327d161f1e7cb0f..22bb2b14cb6aa04b5a685b58ea8da70b21ff07a7 100644 (file)
--- a/server/core.c
+++ b/server/core.c
@@ -1271,6 +1271,7 @@ AP_DECLARE(const char *) ap_resolve_env(apr_pool_t *p, const char * word)
 static int reset_config_defines(void *dummy)
 {
     ap_server_config_defines = saved_server_config_defines;
+    saved_server_config_defines = NULL;
     server_config_defined_vars = NULL;
     return OK;
 }