]> granicus.if.org Git - clang/commitdiff
Change signature of __builtin_rotateright64 back to unsigned
authorKarl-Johan Karlsson <karl-johan.karlsson@ericsson.com>
Mon, 16 Sep 2019 09:52:23 +0000 (09:52 +0000)
committerKarl-Johan Karlsson <karl-johan.karlsson@ericsson.com>
Mon, 16 Sep 2019 09:52:23 +0000 (09:52 +0000)
The signature of __builtin_rotateright64 was by misstake changed from
unsigned to signed in r360863, this patch will change it back to
unsigned as intended.

This fixes pr43309

Reviewers: efriedma, hans

Reviewed By: hans

Differential Revision: https://reviews.llvm.org/D67606

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@371969 91177308-0d34-0410-b5e6-96231b3b80d8

include/clang/Basic/Builtins.def
test/CodeGen/avr-builtins.c

index c1fcd9bb306f50d105dff30dff416b5ab2b1e7e2..6dd0d3a7310dd22c79a5f4291b94f23317343cfd 100644 (file)
@@ -461,7 +461,7 @@ BUILTIN(__builtin_rotateleft64, "UWiUWiUWi", "nc")
 BUILTIN(__builtin_rotateright8, "UcUcUc", "nc")
 BUILTIN(__builtin_rotateright16, "UsUsUs", "nc")
 BUILTIN(__builtin_rotateright32, "UZiUZiUZi", "nc")
-BUILTIN(__builtin_rotateright64, "UWiUWiWi", "nc")
+BUILTIN(__builtin_rotateright64, "UWiUWiUWi", "nc")
 
 // Random GCC builtins
 BUILTIN(__builtin_constant_p, "i.", "nctu")
index cbba6b2f2a2e5f04eed3c4d0260424dc6bf1050b..8fa983a782393323c9eea32f91093477bb8657e8 100644 (file)
@@ -1,5 +1,9 @@
 // RUN: %clang_cc1 -triple avr-unknown-unknown -emit-llvm -o - %s | FileCheck %s
 
+// Check that the parameter types match. This verifies pr43309.
+// RUN: %clang_cc1 -triple avr-unknown-unknown -Wconversion -verify %s
+// expected-no-diagnostics
+
 unsigned char bitrev8(unsigned char data) {
     return __builtin_bitreverse8(data);
 }