Fix float.fromhex test to give additional information on failure. This

change is aimed at diagnosing issue 3633 (test_float fails on Solaris).

Reviewed by Benjamin Peterson

diff --git a/Lib/test/test_float.py b/Lib/test/test_float.py
index 3f4998d4a4a3b1da1a9da3c55e0c9bba25baaa66..ab791a3a34c664dafc62081bfef4bcf74bf98183 100644 (file)
--- a/Lib/test/test_float.py
+++ b/Lib/test/test_float.py
@@ -417,7 +417,13 @@ class HexFloatTestCase(unittest.TestCase):
             '0x1p0\0 0x1p0',  # embedded null byte is not end of string
             ]
         for x in invalid_inputs:
-            self.assertRaises(ValueError, fromHex, x)
+            try:
+                result = fromHex(x)
+            except ValueError:
+                pass
+            else:
+                self.fail('Expected float.fromhex(%r) to raise ValueError; '
+                          'got %r instead' % (x, result))
 
 
     def test_from_hex(self):