Safer implementation.

Thanks Marcus.

diff --git a/ext/standard/var.c b/ext/standard/var.c
index 89db9e7c0f88dc1661f4df0a5baa2645acc9837f..4414186b3b76c9d0dfa6eee3914555e431ed4069 100644 (file)
--- a/ext/standard/var.c
+++ b/ext/standard/var.c
@@ -532,11 +532,12 @@ static void php_var_serialize_intern(smart_str *buf, zval **struc, HashTable *va
                        return;
 
                case IS_DOUBLE: {
-                               char s[256];
+                               char *s;
                                ulong slen;
 
-                               slen = sprintf(s, "d:%.252g;", Z_DVAL_PP(struc));
+                               slen = spprintf(&s, 0, "d:%.100g;", Z_DVAL_PP(struc));
                                smart_str_appendl(buf, s, slen);
+                               efree(s);
                                return;
                        }