]> granicus.if.org Git - php/commitdiff
Fix bogus $PHP_PCRE_REGEX checks
authorNikita Popov <nikita.ppv@gmail.com>
Fri, 1 Feb 2019 10:41:18 +0000 (11:41 +0100)
committerNikita Popov <nikita.ppv@gmail.com>
Fri, 1 Feb 2019 10:42:41 +0000 (11:42 +0100)
This variable was dropped in the pkg-config migration, which resulted
in spurious warnings about using valgrind with external PCRE. Fix the
checks to use the right variable.

ext/pcre/config0.m4

index 77ab9f5c600c6731ac8da1fd3c09c504498afbb3..cfacd6ca8e4c9f1917eeb8d5a639471cd357b38f 100644 (file)
@@ -68,20 +68,18 @@ else
   AC_DEFINE(HAVE_BUNDLED_PCRE, 1, [ ])
   AC_DEFINE(PCRE2_CODE_UNIT_WIDTH, 8, [ ])
 
-  if test "$PHP_PCRE_REGEX" != "no"; then
-    AC_MSG_CHECKING([whether to enable PCRE JIT functionality])
-    if test "$PHP_PCRE_JIT" != "no"; then
-      AC_DEFINE(HAVE_PCRE_JIT_SUPPORT, 1, [ ])
-      AC_MSG_RESULT([yes])
-    else
+  AC_MSG_CHECKING([whether to enable PCRE JIT functionality])
+  if test "$PHP_PCRE_JIT" != "no"; then
+    AC_DEFINE(HAVE_PCRE_JIT_SUPPORT, 1, [ ])
+    AC_MSG_RESULT([yes])
+  else
     AC_MSG_RESULT([no])
-    fi
   fi
 fi
 
 PHP_ARG_WITH(pcre-valgrind,,[  --with-pcre-valgrind=DIR
                           Enable PCRE valgrind support. Developers only!], no, no)
-  if test "$PHP_PCRE_REGEX" != "yes" && test "$PHP_PCRE_REGEX" != "no"; then
+  if test "$PHP_EXTERNAL_PCRE" != "no"; then
     AC_MSG_WARN([PHP is going to be linked with an external PCRE, --with-pcre-valgrind has no effect])
   else
     if test "$PHP_PCRE_VALGRIND" != "no"; then