Improve wording of error message when a postgresql.conf setting is

ignored because it can only be set at server start.  In particular,
hiding the main reason in the detail message was suboptimal.

diff --git a/src/backend/utils/misc/guc-file.l b/src/backend/utils/misc/guc-file.l
index 3bd466b240cd503b07df98a1a52845cd0f63f039..a425cd48ac0f490c1e2221e5f79382717f6a7d06 100644 (file)
--- a/src/backend/utils/misc/guc-file.l
+++ b/src/backend/utils/misc/guc-file.l
@@ -4,7 +4,7 @@
  *
  * Copyright (c) 2000-2009, PostgreSQL Global Development Group
  *
- * $PostgreSQL: pgsql/src/backend/utils/misc/guc-file.l,v 1.60 2009/09/17 20:54:03 petere Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/misc/guc-file.l,v 1.61 2009/09/17 21:15:18 petere Exp $
  */
 
 %{
@@ -260,9 +260,8 @@ ProcessConfigFile(GucContext context)
                {
                        ereport(elevel,
                                        (errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
-                                        errmsg("attempted change of parameter \"%s\" ignored",
-                                                       gconf->name),
-                                        errdetail("This parameter cannot be changed after server start.")));
+                                        errmsg("parameter \"%s\" cannot be changed without restarting the server",
+                                                       gconf->name)));
                        continue;
                }
 

diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index cfa71e0cc11ab8701c3e81b0779ef5616489434c..17bbbd7cb4aa9f4ed3579e4fe210bc8afbb5e6fa 100644 (file)
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -10,7 +10,7 @@
  * Written by Peter Eisentraut <peter_e@gmx.net>.
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.517 2009/09/11 19:17:03 tgl Exp $
+ *       $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.518 2009/09/17 21:15:18 petere Exp $
  *
  *--------------------------------------------------------------------
  */
@@ -4599,18 +4599,16 @@ set_config_option(const char *name, const char *value,
                                if (changeVal && !is_newvalue_equal(record, value))
                                        ereport(elevel,
                                                        (errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
-                                          errmsg("attempted change of parameter \"%s\" ignored",
-                                                         name),
-                                                        errdetail("This parameter cannot be changed after server start.")));
+                                          errmsg("parameter \"%s\" cannot be changed without restarting the server",
+                                                         name)));
                                return true;
                        }
                        if (context != PGC_POSTMASTER)
                        {
                                ereport(elevel,
                                                (errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),
-                                          errmsg("attempted change of parameter \"%s\" ignored",
-                                                         name),
-                                                errdetail("This parameter cannot be changed after server start.")));
+                                          errmsg("parameter \"%s\" cannot be changed without restarting the server",
+                                                         name)));
                                return false;
                        }
                        break;