Merged revisions 72835 via svnmerge from

svn+ssh://pythondev@svn.python.org/python/trunk

........
  r72835 | r.david.murray | 2009-05-22 20:48:58 -0400 (Fri, 22 May 2009) | 4 lines

  Fix Issue #4066: smtplib.SMTP_SSL._get_socket now correctly returns
  the socket.  Patch by Farhan Ahmad, test by Marcin Bachry.
........

diff --git a/Lib/smtplib.py b/Lib/smtplib.py
index 0a12a979318cf6d3a5dc1a022fdca43f9dde9728..d8d717c05b55833c60daf26fde29e1c42f546f49 100755 (executable)
--- a/Lib/smtplib.py
+++ b/Lib/smtplib.py
@@ -757,9 +757,10 @@ if _have_ssl:
 
         def _get_socket(self, host, port, timeout):
             if self.debuglevel > 0: print('connect:', (host, port), file=stderr)
-            self.sock = socket.create_connection((host, port), timeout)
-            self.sock = ssl.wrap_socket(self.sock, self.keyfile, self.certfile)
-            self.file = SSLFakeFile(self.sock)
+            new_socket = socket.create_connection((host, port), timeout)
+            new_socket = ssl.wrap_socket(new_socket, self.keyfile, self.certfile)
+            self.file = SSLFakeFile(new_socket)
+            return new_socket
 
     __all__.append("SMTP_SSL")
 

diff --git a/Lib/test/test_smtpnet.py b/Lib/test/test_smtpnet.py
new file mode 100644 (file)
index 0000000..5ca4195
--- /dev/null
+++ b/Lib/test/test_smtpnet.py
@@ -0,0 +1,26 @@
+#!/usr/bin/env python
+
+import unittest
+from test import support
+import smtplib
+
+support.requires(
+    "network",
+    "use of network resource is not enabled and "
+    "test requires Internet access for communication with smtp.gmail.com:465",
+    )
+
+class SmtpSSLTest(unittest.TestCase):
+    testServer = 'smtp.gmail.com'
+    remotePort = 465
+
+    def test_connect(self):
+        server = smtplib.SMTP_SSL(self.testServer, self.remotePort)
+        server.ehlo()
+        server.quit()
+
+def test_main():
+    support.run_unittest(SmtpSSLTest)
+
+if __name__ == "__main__":
+    test_main()

diff --git a/Misc/ACKS b/Misc/ACKS
index 8a86f734ed4b36065fb04121719045e46a0695ee..f14d45d2650bb89481bc6573a5891cbdc3683bdc 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -11,6 +11,7 @@ PS: In the standard Python distribution, this file is encoded in Latin-1.
 
 David Abrahams
 Jim Ahlstrom
+Farhan Ahmad
 Jyrki Alakuijala
 Billy G. Allie
 Kevin Altis
@@ -28,6 +29,7 @@ Jan-Hein B"uhrman
 Donovan Baarda
 Attila Babo
 Alfonso Baciero
+Marcin Bachry
 Dwayne Bailey
 Stig Bakken
 Greg Ball

diff --git a/Misc/NEWS b/Misc/NEWS
index ea5d09025f51e091d26c5549c683cd2ec15694fc..19e2deac9c11f956f6583a6b83394314b1885c29 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -29,6 +29,9 @@ Core and Builtins
 Library
 -------
 
+- Issue #4066: smtplib.SMTP_SSL._get_socket now correctly returns the socket.
+  Patch by Farhan Ahmad, test by Marcin Bachry.
+
 - Issue #2116: Weak references and weak dictionaries now support copy()ing and
   deepcopy()ing.