tests/s390_sthyi.c: make utility functions inline

When built with --enable-gcc-Werror, s390_sthyi test build fails
with the following error:

	s390_sthyi.c:63:1: error: ‘print_u8’ defined but not used [-Werror=unused-function]
	 print_u8(const char *prefix, unsigned char *buf, unsigned int offs, bool zero)
	 ^~~~~~~~

Apparently, after some back and forth, all occurrences of printing u8
values landed under verbose printing, so this function is no longer
used in non-verbose mode.  Let's avoid this in the future by inlining
all the utility functions in this test.

* tests/s390_sthyi.c (print_0x8, print_u8, print_u16, print_x32,
print_weight, ebcdic2ascii, is_empty, print_ebcdic): Add inline
qualifier.
[!VERBOSE] (is_empty): Remove "# if VERBOSE" guard.

diff --git a/tests/s390_sthyi.c b/tests/s390_sthyi.c
index f3c309a10cfce606438fb21fc0fefb9c105d847d..8f6bbfb197f3e8cfafc28519c0506337b83b5bc6 100644 (file)
--- a/tests/s390_sthyi.c
+++ b/tests/s390_sthyi.c
@@ -47,7 +47,7 @@
 #  define VERBOSE 0
 # endif
 
-static bool
+static inline bool
 print_0x8(const char *prefix, unsigned char *buf, unsigned int offs, bool zero)
 {
        if (!zero && !buf[offs])
@@ -58,7 +58,7 @@ print_0x8(const char *prefix, unsigned char *buf, unsigned int offs, bool zero)
        return true;
 }
 
-static bool
+static inline bool
 print_u8(const char *prefix, unsigned char *buf, unsigned int offs, bool zero)
 {
        if (!zero && !buf[offs])
@@ -69,7 +69,7 @@ print_u8(const char *prefix, unsigned char *buf, unsigned int offs, bool zero)
        return true;
 }
 
-static bool
+static inline bool
 print_u16(const char *prefix, unsigned char *buf, unsigned int offs, bool zero)
 {
        uint16_t val = *(uint16_t *) (buf + offs);
@@ -82,7 +82,7 @@ print_u16(const char *prefix, unsigned char *buf, unsigned int offs, bool zero)
        return true;
 }
 
-static bool
+static inline bool
 print_x32(const char *prefix, unsigned char *buf, unsigned int offs, bool zero)
 {
        uint32_t val = *(uint32_t *) (buf + offs);
@@ -95,7 +95,7 @@ print_x32(const char *prefix, unsigned char *buf, unsigned int offs, bool zero)
        return true;
 }
 
-static bool
+static inline bool
 print_weight(const char *prefix, unsigned char *buf, unsigned int offs,
             bool zero)
 {
@@ -114,7 +114,7 @@ print_weight(const char *prefix, unsigned char *buf, unsigned int offs,
        return false;
 }
 
-static char *
+static inline char *
 ebcdic2ascii(unsigned char *ebcdic, size_t size)
 {
        static char ascii_buf[EBCDIC_MAX_LEN];
@@ -168,8 +168,7 @@ ebcdic2ascii_end:
        return ascii_buf;
 }
 
-# if VERBOSE
-static bool
+static inline bool
 is_empty(unsigned char *ptr, size_t size)
 {
        size_t i;
@@ -179,9 +178,8 @@ is_empty(unsigned char *ptr, size_t size)
 
        return i == size;
 }
-# endif /* !VERBOSE */
 
-static bool
+static inline bool
 print_ebcdic(const char *prefix, unsigned char *addr, unsigned int offs,
             size_t size, bool zero, bool blank)
 {