Issue #24913: Fix overrun error in deque.index().

diff --git a/Lib/test/test_deque.py b/Lib/test/test_deque.py
index b858509684129c70dba3a20922604c7a1fdfc93d..87187161ab30d84bbc2febf7cfa31bec431bd339 100644 (file)
--- a/Lib/test/test_deque.py
+++ b/Lib/test/test_deque.py
@@ -289,6 +289,11 @@ class TestBasic(unittest.TestCase):
                     else:
                         self.assertEqual(d.index(element, start, stop), target)
 
+    def test_insert_bug_24913(self):
+        d = deque('A' * 3)
+        with self.assertRaises(ValueError):
+            i = d.index("Hello world", 0, 4)
+
     def test_insert(self):
         # Test to make sure insert behaves like lists
         elements = 'ABCDEFGHI'

diff --git a/Misc/NEWS b/Misc/NEWS
index 63b959d4110da3a5ec06d449596015f5271193e8..64aa0e1fa7fe1bf025e1ffc9d15ce59639b69e45 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -18,6 +18,9 @@ Library
   header in part headers. Patch written by Peter Landry and reviewed by Pierre
   Quentel.
 
+- Issue #24913: Fix overrun error in deque.index().
+  Found by John Leitch and Bryce Darling.
+
 - Issue #24774: Fix docstring in http.server.test. Patch from Chiu-Hsiang Hsu.
 
 - Issue #21159: Improve message in configparser.InterpolationMissingOptionError.

diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c
index 830c5b83ebcb925a2f7a66875dded11683a8b599..3856d83fb4e17fc3ee6744f06900e8b21fff26b8 100644 (file)
--- a/Modules/_collectionsmodule.c
+++ b/Modules/_collectionsmodule.c
@@ -924,6 +924,8 @@ deque_index(dequeobject *deque, PyObject *args)
         if (stop < 0)
             stop = 0;
     }
+    if (stop > Py_SIZE(deque))
+        stop = Py_SIZE(deque);
 
     for (i=0 ; i<stop ; i++) {
         if (i >= start) {