Fix intermittent error in pdo_mysql___construct_options.phpt

For the love of god, don't write tests based on mt_rand!

diff --git a/ext/pdo_mysql/tests/pdo_mysql___construct_options.phpt b/ext/pdo_mysql/tests/pdo_mysql___construct_options.phpt
index 9482a13bfacabf70c7439d531651fa2fc85372e9..b7a52127c52bb3435cd6d6804a3ffa4135e7ea58 100644 (file)
--- a/ext/pdo_mysql/tests/pdo_mysql___construct_options.phpt
+++ b/ext/pdo_mysql/tests/pdo_mysql___construct_options.phpt
@@ -76,9 +76,7 @@ MySQLPDOTest::skip();
                if (!is_object($db = new PDO($dsn, $user, $pass, array())))
                        printf("[002] Expecting object got %s/%s¸\n", gettype($db), $db);
 
-               do {
-                       $invalid = mt_rand(-1000, 1000);
-               } while (isset($valid_options[$invalid]));
+        $invalid = 999;
                if (is_object($db = new PDO($dsn, $user, $pass, array($invalid => true))))
                        printf("[003] [TODO][CHANGEREQUEST] Please, lets not ignore invalid options and bail out!\n");
 

diff --git a/ext/pdo_mysql/tests/pdo_mysql_get_attribute.phpt b/ext/pdo_mysql/tests/pdo_mysql_get_attribute.phpt
index 2eb34cd07627413a55d47f77b779007f43e063c4..51310faa9e2855b4fc19ddfffbb0911a419cade5 100644 (file)
--- a/ext/pdo_mysql/tests/pdo_mysql_get_attribute.phpt
+++ b/ext/pdo_mysql/tests/pdo_mysql_get_attribute.phpt
@@ -15,13 +15,6 @@ if (false == MySQLPDOTest::detect_transactional_mysql_engine($db))
        $db = MySQLPDOTest::factory();
        MySQLPDOTest::createTestTable($db, MySQLPDOTest::detect_transactional_mysql_engine($db));
 
-       function find_invalid_int($valid_options) {
-               do {
-                       $invalid = mt_rand(-10000, 10000);
-               } while (in_array($invalid, $valid_options));
-               return $invalid;
-       }
-
        function set_and_get($offset, $db, $attribute, $value) {
 
                $value_type = gettype($value);