]> granicus.if.org Git - php/commitdiff
abstain from using xmlCleanupParser
authorAnatol Belski <ab@php.net>
Tue, 17 Feb 2015 09:37:52 +0000 (10:37 +0100)
committerAnatol Belski <ab@php.net>
Tue, 17 Feb 2015 09:37:52 +0000 (10:37 +0100)
Depending on circumstances, usage of xmlCleanupParser can affect
the thread local storage, or even cause crashes in single threaded
programs. On shutdown the memory will be freed anyway, however
not using xmlCleanupParser helps to avoid possible shutdown
crashes.

ext/libxml/libxml.c

index 0eee3ff2bd5b3a14f42f7f06b759ebd7b29d3f65..a9490f79872d06429cbaff3fc15f62b57d377035 100644 (file)
@@ -752,7 +752,7 @@ PHP_LIBXML_API void php_libxml_shutdown(void)
 #if defined(LIBXML_SCHEMAS_ENABLED)
                xmlRelaxNGCleanupTypes();
 #endif
-               xmlCleanupParser();
+               /* xmlCleanupParser(); */
                zend_hash_destroy(&php_libxml_exports);
 
                xmlSetExternalEntityLoader(_php_libxml_default_entity_loader);