Change section flag character for SHF_LINK_ORDER to "o".

GAS uses "m" as a compatibility alias for "M" (SHF_MERGE).

"o" is free, except on ia64, where it already means SHF_LINK_ORDER.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@299479 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/docs/Extensions.rst b/docs/Extensions.rst
index 782539dda58e115a43845bb27825498707f51ab2..14fea30204b4cb235a1175f6889daffc4687aa47 100644 (file)
--- a/docs/Extensions.rst
+++ b/docs/Extensions.rst
@@ -204,7 +204,7 @@ For example, the following code creates two sections named ``.text``.
 The unique number is not present in the resulting object at all. It is just used
 in the assembler to differentiate the sections.
 
-The 'm' flag is mapped to SHF_LINK_ORDER. If it is present, a symbol
+The 'o' flag is mapped to SHF_LINK_ORDER. If it is present, a symbol
 must be given that identifies the section to be placed is the
 .sh_link.
 
@@ -212,14 +212,14 @@ must be given that identifies the section to be placed is the
 
         .section .foo,"a",@progbits
         .Ltmp:
-        .section .bar,"am",@progbits,.Ltmp
+        .section .bar,"ao",@progbits,.Ltmp
 
 which is equivalent to just
 
 .. code-block:: gas
 
         .section .foo,"a",@progbits
-        .section .bar,"am",@progbits,.foo
+        .section .bar,"ao",@progbits,.foo
 
 
 Target Specific Behaviour

diff --git a/lib/MC/MCParser/ELFAsmParser.cpp b/lib/MC/MCParser/ELFAsmParser.cpp
index 3476a02e0fd7ffa29ce23c449949d4a5778a4ee3..ed911cbc756e487c83ca474d2cdc478a816810db 100644 (file)
--- a/lib/MC/MCParser/ELFAsmParser.cpp
+++ b/lib/MC/MCParser/ELFAsmParser.cpp
@@ -298,7 +298,7 @@ static unsigned parseSectionFlags(StringRef flagsStr, bool *UseLastGroup) {
     case 'w':
       flags |= ELF::SHF_WRITE;
       break;
-    case 'm':
+    case 'o':
       flags |= ELF::SHF_LINK_ORDER;
       break;
     case 'M':

diff --git a/lib/MC/MCSectionELF.cpp b/lib/MC/MCSectionELF.cpp
index 56c51d7539e48aeb4db29b660da054b9e43f94a8..78fe01cca24a3b1adc37b2133fb2b313d4230a0b 100644 (file)
--- a/lib/MC/MCSectionELF.cpp
+++ b/lib/MC/MCSectionELF.cpp
@@ -104,7 +104,7 @@ void MCSectionELF::PrintSwitchToSection(const MCAsmInfo &MAI, const Triple &T,
   if (Flags & ELF::SHF_TLS)
     OS << 'T';
   if (Flags & ELF::SHF_LINK_ORDER)
-    OS << 'm';
+    OS << 'o';
 
   // If there are target-specific flags, print them.
   Triple::ArchType Arch = T.getArch();

diff --git a/test/CodeGen/X86/elf-associated.ll b/test/CodeGen/X86/elf-associated.ll
index 20baa845277213c4ee408aa497aafc0de80a4d6e..361cf66cce728092fa0dfc329f02769b1a522e6b 100644 (file)
--- a/test/CodeGen/X86/elf-associated.ll
+++ b/test/CodeGen/X86/elf-associated.ll
@@ -4,23 +4,23 @@
 @a = global i32 1
 @b = global i32 2, !associated !0
 !0 = !{i32* @a}
-; CHECK-DAG: .section .data.b,"awm",@progbits,a
+; CHECK-DAG: .section .data.b,"awo",@progbits,a
 
 ; Loop is OK. Also, normally -data-sections=0 would place @c and @d in the same section. !associated prevents that.
 @c = global i32 2, !associated !2
 @d = global i32 2, !associated !1
 !1 = !{i32* @c}
 !2 = !{i32* @d}
-; CHECK-DAG: .section .data.c,"awm",@progbits,d
-; CHECK-DAG: .section .data.d,"awm",@progbits,c
+; CHECK-DAG: .section .data.c,"awo",@progbits,d
+; CHECK-DAG: .section .data.d,"awo",@progbits,c
 
 ; BSS is OK.
 @e = global i32 0
 @f = global i32 0, !associated !3
 @g = global i32 1, !associated !3
 !3 = !{i32* @e}
-; CHECK-DAG: .section .bss.f,"awm",@nobits,e
-; CHECK-DAG: .section .data.g,"awm",@progbits,e
+; CHECK-DAG: .section .bss.f,"awo",@nobits,e
+; CHECK-DAG: .section .data.g,"awo",@progbits,e
 
 ; Explicit sections.
 @h = global i32 1, section "aaa"
@@ -29,9 +29,9 @@
 @k = global i32 1, !associated !4
 !4 = !{i32* @h}
 ; CHECK-DAG: .section  aaa,"aw",@progbits
-; CHECK-DAG: .section  bbb,"awm",@progbits,h,unique,1
-; CHECK-DAG: .section  bbb,"awm",@progbits,h,unique,2
-; CHECK-DAG: .section  .data.k,"awm",@progbits,h
+; CHECK-DAG: .section  bbb,"awo",@progbits,h,unique,1
+; CHECK-DAG: .section  bbb,"awo",@progbits,h,unique,2
+; CHECK-DAG: .section  .data.k,"awo",@progbits,h
 
 ; Non-GlobalObject metadata.
 @l = global i32 1, section "ccc", !associated !5

diff --git a/test/MC/ELF/section-metadata-err1.s b/test/MC/ELF/section-metadata-err1.s
index eb468f6b93776235e968ddc48026a6e6ad4d71c2..682f0e82f30d372a2a7abd80c4a00900f25c967b 100644 (file)
--- a/test/MC/ELF/section-metadata-err1.s
+++ b/test/MC/ELF/section-metadata-err1.s
@@ -2,4 +2,4 @@
 
 // CHECK: error: symbol is not in a section: foo
 
-        .section .shf_metadata,"am",@progbits,foo
+        .section .shf_metadata,"ao",@progbits,foo

diff --git a/test/MC/ELF/section-metadata-err2.s b/test/MC/ELF/section-metadata-err2.s
index 032e000453b021187ef93c72351fe74d3f417c63..1912f67d0e0f16f91b37aad418e85a3289c86622 100644 (file)
--- a/test/MC/ELF/section-metadata-err2.s
+++ b/test/MC/ELF/section-metadata-err2.s
@@ -3,4 +3,4 @@
 // CHECK: error: symbol is not in a section: foo
 
         .quad foo
-        .section .shf_metadata,"am",@progbits,foo
+        .section .shf_metadata,"ao",@progbits,foo

diff --git a/test/MC/ELF/section-metadata-err3.s b/test/MC/ELF/section-metadata-err3.s
index 4d8d0e23f961c761d2f469be5ab193e38d86595c..388ca377fd42eb312b558d19b79a5b048fd00ce8 100644 (file)
--- a/test/MC/ELF/section-metadata-err3.s
+++ b/test/MC/ELF/section-metadata-err3.s
@@ -3,4 +3,4 @@
 // CHECK: error: symbol is not in a section: foo
 
         foo = 42
-        .section .shf_metadata,"am",@progbits,foo
+        .section .shf_metadata,"ao",@progbits,foo

diff --git a/test/MC/ELF/section-metadata-err4.s b/test/MC/ELF/section-metadata-err4.s
index 3c843c04643666e614bf79f8e7e0b6ba349468fd..d7677d292f70e7a359b3b83036aab352c8b5a6f7 100644 (file)
--- a/test/MC/ELF/section-metadata-err4.s
+++ b/test/MC/ELF/section-metadata-err4.s
@@ -2,4 +2,4 @@
 
 // CHECK: error: expected metadata symbol
 
-        .section .shf_metadata,"am",@progbits
+        .section .shf_metadata,"ao",@progbits

diff --git a/test/MC/ELF/section.s b/test/MC/ELF/section.s
index 2accab0e4498176113a73ddad5890ff6bc575260..a852b01eb6e5ff774f95db8e48ad4482b4e091d9 100644 (file)
--- a/test/MC/ELF/section.s
+++ b/test/MC/ELF/section.s
@@ -163,12 +163,12 @@ bar:
 .Lshf_metadata_target2_2:
         .quad 0
 
-.section .shf_metadata1,"am",@progbits,.Lshf_metadata_target2_1
-.section .shf_metadata2,"am",@progbits,.Lshf_metadata_target2_2
-.section .shf_metadata3,"am",@progbits,.shf_metadata_target1
-// ASM: .section .shf_metadata1,"am",@progbits,.Lshf_metadata_target2_1
-// ASM: .section .shf_metadata2,"am",@progbits,.Lshf_metadata_target2_2
-// ASM: .section .shf_metadata3,"am",@progbits,.shf_metadata_target1
+.section .shf_metadata1,"ao",@progbits,.Lshf_metadata_target2_1
+.section .shf_metadata2,"ao",@progbits,.Lshf_metadata_target2_2
+.section .shf_metadata3,"ao",@progbits,.shf_metadata_target1
+// ASM: .section .shf_metadata1,"ao",@progbits,.Lshf_metadata_target2_1
+// ASM: .section .shf_metadata2,"ao",@progbits,.Lshf_metadata_target2_2
+// ASM: .section .shf_metadata3,"ao",@progbits,.shf_metadata_target1
 
 // CHECK:      Section {
 // CHECK:        Index: 22