]> granicus.if.org Git - apache/commitdiff
This definitely gets the award for least useful error message of the month.
authorCliff Woolley <jwoolley@apache.org>
Thu, 30 May 2002 22:39:08 +0000 (22:39 +0000)
committerCliff Woolley <jwoolley@apache.org>
Thu, 30 May 2002 22:39:08 +0000 (22:39 +0000)
Not only should it just say "can't do that on win32," which is after all
the bottom line, it was spitting out openssl error messages which were
totally useless.  Eg:

[30/May/2002 17:31:17 05760] [error] Init: PassPhraseDialog BuiltIn not
supported in server private key from file
F:/Apache/Apache2/conf/ssl/secure.key (OpenSSL library error follows)
[30/May/2002 17:31:17 05760] [error] OpenSSL: error:0D084069:asn1
encoding routines:d2i_ASN1_SET:bad tag
[30/May/2002 17:31:17 05760] [error] OpenSSL: error:0D09D082:asn1
encoding routines:d2i_RSAPrivateKey:parsing
[30/May/2002 17:31:17 05760] [error] OpenSSL: error:0D09B00D:asn1
encoding routines:d2i_PrivateKey:ASN1 lib

Which is essentially saying "OpenSSL couldn't read your private key because
it was encrypted, and we can't get the passphrase the way you asked us to
on this platform."

Brought to my attention by the inquiry of:  Chris Hsiang <chsiang@ivivos.com>

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@95415 13f79535-47bb-0310-9956-ffa450edef68

modules/ssl/ssl_engine_pphrase.c

index b9562ee8a62507d2e2381816b89e51affb3e107e..275758e933adb31c2a8165bdd42e92ebf8719e77 100644 (file)
@@ -418,10 +418,9 @@ void ssl_pphrase_Handle(server_rec *s, apr_pool_t *p)
 #ifdef WIN32
                 if (sc->server->pphrase_dialog_type == SSL_PPTYPE_BUILTIN) {
                     ap_log_error(APLOG_MARK, APLOG_ERR, 0, s,
-                                 "Init: PassPhraseDialog BuiltIn not "
-                                 "supported in server private key from file "
-                                 "%s", szPath);
-                    ssl_log_ssl_error(APLOG_MARK, APLOG_ERR, s);
+                                 "Init: SSLPassPhraseDialog builtin is not "
+                                 "supported on Win32 (key file "
+                                 "%s)", szPath);
                     ssl_die();
                 }
 #endif /* WIN32 */