]> granicus.if.org Git - postgresql/commitdiff
Fix 1-byte buffer overrun when OID exceeds 1 billion. This probably can't
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 22 Nov 2006 21:13:11 +0000 (21:13 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 22 Nov 2006 21:13:11 +0000 (21:13 +0000)
cause any serious harm in normal cases, but if you have gcc buffer overrun
checking turned on, that will notice.  Found by Jack Orenstein.  Problem
was already fixed in CVS HEAD.

src/bin/psql/common.c

index 862fa4d6670e7aac0b68a9be9bc443a0e3bd1fca..4e15e0af475552b534dae77549549c4bf1f6645b 100644 (file)
@@ -3,7 +3,7 @@
  *
  * Copyright (c) 2000-2003, PostgreSQL Global Development Group
  *
- * $Header: /cvsroot/pgsql/src/bin/psql/common.c,v 1.76.2.1 2003/11/12 22:55:42 tgl Exp $
+ * $Header: /cvsroot/pgsql/src/bin/psql/common.c,v 1.76.2.2 2006/11/22 21:13:11 tgl Exp $
  */
 #include "postgres_fe.h"
 #include "common.h"
@@ -556,7 +556,7 @@ PrintQueryResults(PGresult *results)
 
                case PGRES_COMMAND_OK:
                        {
-                               char            buf[10];
+                               char            buf[16];
 
                                success = true;
                                sprintf(buf, "%u", (unsigned int) PQoidValue(results));