pg_upgrade: remove --single-transaction usage

With AtEOXact applied, --single-transaction makes pg_restore slower, and
has the potential to require lock table configuration, so remove the
argument.

Per suggestion from Tom.

diff --git a/contrib/pg_upgrade/pg_upgrade.c b/contrib/pg_upgrade/pg_upgrade.c
index 85997e59bf77ad787645cc15ce6b529f5350f1c9..88494b8d6deeb8ce65f71d2301eb8b8f45efa796 100644 (file)
--- a/contrib/pg_upgrade/pg_upgrade.c
+++ b/contrib/pg_upgrade/pg_upgrade.c
@@ -314,12 +314,11 @@ create_new_objects(void)
                snprintf(log_file_name, sizeof(log_file_name), DB_DUMP_LOG_FILE_MASK, old_db->db_oid);
 
                /*
-                *      Using pg_restore --single-transaction is faster than other
-                *      methods, like --jobs.  pg_dump only produces its output at the
-                *      end, so there is little parallelism using the pipe.
+                *      pg_dump only produces its output at the end, so there is little
+                *      parallelism if using the pipe.
                 */
                parallel_exec_prog(log_file_name, NULL,
-                                 "\"%s/pg_restore\" %s --exit-on-error --single-transaction --verbose --dbname \"%s\" \"%s\"",
+                                 "\"%s/pg_restore\" %s --exit-on-error --verbose --dbname \"%s\" \"%s\"",
                                  new_cluster.bindir, cluster_conn_opts(&new_cluster),
                                  old_db->db_name, sql_file_name);
        }