Fix uses of context->changed as a counter.

The first was in mx_update_tables(), but only when "not committing".
This is used by mh/maildir during an "occult" update, and in imap when
expunging the mailbox.  It meant to simply turn on changed when a
single changed header is seen.

The second use was in imap_sync_message_for_copy().  Previously this
was used for a server side copy/save, but is now also used for
fast-trash copying.  Remove the code that was trying to decrement the
counter: this function is not capable of properly setting a status
bit.

diff --git a/imap/imap.c b/imap/imap.c
index d22a9e19b0fc7063afb7bfcc6e795775d554ee4a..dbc479104949a5b08bea71e7f693ef028c2353e0 100644 (file)
--- a/imap/imap.c
+++ b/imap/imap.c
@@ -1147,10 +1147,7 @@ int imap_sync_message_for_copy(struct ImapData *idata, struct Header *hdr,
   if (!compare_flags_for_copy(hdr))
   {
     if (hdr->deleted == HEADER_DATA(hdr)->deleted)
-    {
       hdr->changed = false;
-      idata->ctx->changed = false;
-    }
     return 0;
   }
 
@@ -1213,10 +1210,7 @@ int imap_sync_message_for_copy(struct ImapData *idata, struct Header *hdr,
 
   hdr->active = true;
   if (hdr->deleted == HEADER_DATA(hdr)->deleted)
-  {
     hdr->changed = false;
-    idata->ctx->changed = false;
-  }
 
   return 0;
 }